Issue 10096001: Remove support for bitmap printing in pepper

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -189 lines)			Patch
M	chrome/renderer/print_web_view_helper.cc	View	1 2 3	3 chunks	+8 lines, -2 lines	0 comments	Download
M	ppapi/api/dev/ppp_printing_dev.idl	View		3 chunks	+4 lines, -7 lines	3 comments	Download
M	ppapi/c/dev/ppp_printing_dev.h	View		4 chunks	+5 lines, -8 lines	0 comments	Download
M	ppapi/examples/printing/printing.cc	View	1 2	4 chunks	+32 lines, -18 lines	1 comment	Download
M	webkit/plugins/ppapi/ppapi_plugin_instance.h	View		1 chunk	+0 lines, -11 lines	1 comment	Download
M	webkit/plugins/ppapi/ppapi_plugin_instance.cc	View		3 chunks	+0 lines, -143 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

8 years, 8 months ago (2012-04-16 04:53:52 UTC) #2

lgtm w/nit

http://codereview.chromium.org/10096001/diff/1005/ppapi/api/dev/ppp_printing_...
File ppapi/api/dev/ppp_printing_dev.idl (left):

http://codereview.chromium.org/10096001/diff/1005/ppapi/api/dev/ppp_printing_...
ppapi/api/dev/ppp_printing_dev.idl:24: PP_PRINTOUTPUTFORMAT_RASTER     = 1u <<
0,
There's no particular reason to remove it from here. AFAIK, we don't support
PostScript or EMF either.

http://codereview.chromium.org/10096001/diff/1005/ppapi/api/dev/ppp_printing_...
ppapi/api/dev/ppp_printing_dev.idl:71: * This is a PPB_ImageData resource if the
output format is
(Though I always wondered what it was supposed to do for multiple pages in the
raster case. I assumed wrongly that it would call PrintPages() multiple times,
once for each page....)

http://codereview.chromium.org/10096001/diff/1005/ppapi/api/dev/ppp_printing_...
File ppapi/api/dev/ppp_printing_dev.idl (right):

http://codereview.chromium.org/10096001/diff/1005/ppapi/api/dev/ppp_printing_...
ppapi/api/dev/ppp_printing_dev.idl:76: /** Ends the print session. Further calls
to PrintPage will fail. */
I suppose that, while you're here: s/PrintPage/&s/

http://codereview.chromium.org/10096001/diff/1005/ppapi/examples/printing/pri...
File ppapi/examples/printing/printing.cc (right):

http://codereview.chromium.org/10096001/diff/1005/ppapi/examples/printing/pri...
ppapi/examples/printing/printing.cc:67: int pdf_len = strlen(pdf_data);
nit: size_t

http://codereview.chromium.org/10096001/diff/1005/webkit/plugins/ppapi/ppapi_...
File webkit/plugins/ppapi/ppapi_plugin_instance.h (right):

http://codereview.chromium.org/10096001/diff/1005/webkit/plugins/ppapi/ppapi_...
webkit/plugins/ppapi/ppapi_plugin_instance.h:431: // print format that we can
handle (we can handle raster and PDF).
s/raster and //

Expand Messages | Collapse Messages