Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10095018: Added a new PyAuto method WaitForDomNode() which allows tests to block until a specified node exist… (Closed)

Created:
8 years, 8 months ago by craigdh
Modified:
8 years, 8 months ago
Reviewers:
frankf, Nirnimesh
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh
Visibility:
Public.

Description

Added a new PyAuto method WaitForDomNode() which allows tests to block until a specified node exists in the DOM. BUG=None TEST=functional/apptest.py Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132506

Patch Set 1 #

Patch Set 2 : Ready for review. #

Total comments: 2

Patch Set 3 : Added a comment noting that the method does not poll. #

Total comments: 2

Patch Set 4 : Created a new exception class JavascriptRuntimeException in place of RuntimeException. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -8 lines) Patch
M chrome/test/functional/apptest.py View 1 chunk +10 lines, -2 lines 0 comments Download
M chrome/test/pyautolib/dom_mutation_observer.js View 5 chunks +43 lines, -2 lines 0 comments Download
M chrome/test/pyautolib/pyauto.py View 1 2 3 3 chunks +30 lines, -4 lines 0 comments Download
M chrome/test/pyautolib/pyauto_errors.py View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
craigdh
8 years, 8 months ago (2012-04-16 17:41:28 UTC) #1
Nirnimesh
LGTM https://chromiumcodereview.appspot.com/10095018/diff/1001/chrome/test/pyautolib/pyauto.py File chrome/test/pyautolib/pyauto.py (right): https://chromiumcodereview.appspot.com/10095018/diff/1001/chrome/test/pyautolib/pyauto.py#newcode2967 chrome/test/pyautolib/pyauto.py:2967: """Waits until a node matching selector exists in ...
8 years, 8 months ago (2012-04-16 23:14:12 UTC) #2
craigdh
https://chromiumcodereview.appspot.com/10095018/diff/1001/chrome/test/pyautolib/pyauto.py File chrome/test/pyautolib/pyauto.py (right): https://chromiumcodereview.appspot.com/10095018/diff/1001/chrome/test/pyautolib/pyauto.py#newcode2967 chrome/test/pyautolib/pyauto.py:2967: """Waits until a node matching selector exists in the ...
8 years, 8 months ago (2012-04-16 23:38:08 UTC) #3
frankf
LGTM with a nit. https://chromiumcodereview.appspot.com/10095018/diff/6001/chrome/test/pyautolib/pyauto.py File chrome/test/pyautolib/pyauto.py (right): https://chromiumcodereview.appspot.com/10095018/diff/6001/chrome/test/pyautolib/pyauto.py#newcode3044 chrome/test/pyautolib/pyauto.py:3044: RuntimeError if the injected javascript ...
8 years, 8 months ago (2012-04-16 23:53:07 UTC) #4
craigdh
https://chromiumcodereview.appspot.com/10095018/diff/6001/chrome/test/pyautolib/pyauto.py File chrome/test/pyautolib/pyauto.py (right): https://chromiumcodereview.appspot.com/10095018/diff/6001/chrome/test/pyautolib/pyauto.py#newcode3044 chrome/test/pyautolib/pyauto.py:3044: RuntimeError if the injected javascript MutationObserver returns an error. ...
8 years, 8 months ago (2012-04-16 23:58:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/10095018/9003
8 years, 8 months ago (2012-04-16 23:58:58 UTC) #6
commit-bot: I haz the power
8 years, 8 months ago (2012-04-17 01:30:39 UTC) #7 
Change committed as 132506

Powered by Google App Engine
This is Rietveld 408576698