Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Unified Diff: lib/compiler/implementation/ssa/codegen.dart

Issue 10095014: Implement interface types. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/ssa/builder.dart ('k') | lib/compiler/implementation/ssa/nodes.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/codegen.dart
diff --git a/lib/compiler/implementation/ssa/codegen.dart b/lib/compiler/implementation/ssa/codegen.dart
index fccab573d47b1e3f9db95a59e5a131da30696344..eaaa0740a72e1bf427e7970f50da35a079550235 100644
--- a/lib/compiler/implementation/ssa/codegen.dart
+++ b/lib/compiler/implementation/ssa/codegen.dart
@@ -1465,13 +1465,16 @@ class SsaCodeGenerator implements HVisitor {
}
void visitIs(HIs node) {
- Element element = node.typeExpression;
+ Type type = node.typeName;
+ Element element = type.element;
if (element.kind === ElementKind.TYPE_VARIABLE) {
compiler.unimplemented("visitIs for type variables");
+ } else if (element.kind === ElementKind.TYPEDEF) {
+ compiler.unimplemented("visitIs for typedefs");
}
compiler.registerIsCheck(element);
LibraryElement coreLibrary = compiler.coreLibrary;
- ClassElement objectClass = coreLibrary.find(const SourceString('Object'));
+ ClassElement objectClass = compiler.objectClass;
HInstruction input = node.expression;
if (node.nullOk) {
beginExpression(JSPrecedence.LOGICAL_OR_PRECEDENCE);
« no previous file with comments | « lib/compiler/implementation/ssa/builder.dart ('k') | lib/compiler/implementation/ssa/nodes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698