Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10095013: fixed signatures for several syscalls that return positive value in correct case (Closed)

Created:
8 years, 8 months ago by vissi
Modified:
8 years, 8 months ago
CC:
native-client-reviews_googlegroups.com, Mark Seaborn
Base URL:
http://git.chromium.org/native_client/nacl-glibc.git@master
Visibility:
Public.

Description

fixed signatures for several syscalls that return positive value in correct case BUG= TEST= Committed: https://git.chromium.org/gitweb?p=native_client/nacl-glibc.git;a=commit;h=e98ec8c

Patch Set 1 #

Patch Set 2 : fixed copy-paste issue. build successful #

Patch Set 3 : done. thanks @khim #

Total comments: 1

Patch Set 4 : fixed NIT #

Patch Set 5 : code style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -80 lines) Patch
M elf/Versions View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M sysdeps/nacl/irt_syscalls.h View 1 2 3 4 1 chunk +21 lines, -21 lines 0 comments Download
M sysdeps/nacl/irt_syscalls.c View 1 2 3 4 3 chunks +22 lines, -20 lines 0 comments Download
M sysdeps/nacl/syscalls.list View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sysdeps/nacl/sysdep.h View 1 2 3 4 9 chunks +38 lines, -22 lines 0 comments Download
M sysdeps/unix/sysv/linux/sys/syscall.h View 1 2 1 chunk +20 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
vissi
Hi, this problem was revealed by testing, updated test code would be uploaded to ccr ...
8 years, 8 months ago (2012-04-16 13:50:52 UTC) #1
vissi
On 2012/04/16 13:50:52, vissi wrote: > Hi, > this problem was revealed by testing, updated ...
8 years, 8 months ago (2012-04-18 11:10:14 UTC) #2
khim
One nit, o/w LGTM https://chromiumcodereview.appspot.com/10095013/diff/2002/sysdeps/nacl/irt_syscalls.h File sysdeps/nacl/irt_syscalls.h (right): https://chromiumcodereview.appspot.com/10095013/diff/2002/sysdeps/nacl/irt_syscalls.h#newcode38 sysdeps/nacl/irt_syscalls.h:38: extern int (*__nacl_irt_epoll_create) (int flags, ...
8 years, 8 months ago (2012-04-18 11:22:21 UTC) #3
vissi
On 2012/04/18 11:22:21, khim wrote: > One nit, o/w LGTM > > https://chromiumcodereview.appspot.com/10095013/diff/2002/sysdeps/nacl/irt_syscalls.h > File ...
8 years, 8 months ago (2012-04-18 11:45:05 UTC) #4
vissi
On 2012/04/18 11:45:05, vissi wrote: > On 2012/04/18 11:22:21, khim wrote: > > One nit, ...
8 years, 8 months ago (2012-04-18 11:58:49 UTC) #5
khim
8 years, 8 months ago (2012-04-18 12:06:18 UTC) #6 
LGTM

Powered by Google App Engine
This is Rietveld 408576698