Disable the signal handlers set by AddressSanitizer.

src/trusted/service_runtime/sel_main_chrome.c

Index: src/trusted/service_runtime/sel_main_chrome.c
===================================================================
--- src/trusted/service_runtime/sel_main_chrome.c	(revision 8264)
+++ src/trusted/service_runtime/sel_main_chrome.c	(working copy)
@@ -33,6 +33,10 @@
 #include "native_client/src/trusted/service_runtime/sel_qualify.h"
 #include "native_client/src/trusted/service_runtime/win/exception_patch/ntdll_patch.h"
 
+#ifdef ADDRESS_SANITIZER

[Mark Seaborn, 2012/04/19 16:16:39]

Can you add a comment to explain what this is for, please?

I suspect we also want a TODO in here to say that when NaCl's signal handler is
enabled by default on Linux, we should replace this.  This is what we'd do:

 * NaCl's signal handler should run first;
 * when NaCl's signal handler notices the crash was in trusted code, it passes
control to the previously-registered ASAN signal handler.

Does that match what you'd expect?

What happens on Mac OS X, though?  Does ASAN still use a signal handler, and how
does it interact with Mac Breakpad's use of Mach exception handling?

+extern __asan_disable_signal_handlers();

[Mark Seaborn, 2012/04/19 16:16:39]

Surely "void __asan_disable_signal_handlers(void);"?  'extern' is redundant on
function prototypes (and IIRC our presubmit scripts reject it?).

Is there not a header file we can #include to get this?

+#endif
+
 static int const kSrpcFd = 5;
 
 struct NaClChromeMainArgs *NaClChromeMainArgsCreate(void) {
@@ -147,6 +151,9 @@
    * channel is set up, and then bail out.
    */
 
+#ifdef ADDRESS_SANITIZER
+  __asan_disable_signal_handlers();

[Mark Seaborn, 2012/04/19 16:16:39]

Can you add a comment to explain what this is for, please?

I suspect we also want a TODO in here to say that when NaCl's signal handler is
enabled by default on Linux, we should replace this.  This is what we'd do:

 * NaCl's signal handler should run first;
 * when NaCl's signal handler notices the crash was in trusted code, it passes
control to the previously-registered ASAN signal handler.

Does that match what you'd expect?

What happens on Mac OS X, though?  Does ASAN still use a signal handler, and how
does it interact with Mac Breakpad's use of Mach exception handling?

+#endif
   /*
    * Ensure this operating system platform is supported.
    */