Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 10095010: removed epoll_create1 (EPOLL_CLOEXEC is not applicable to NaCl, as there is no possibility to fork)… (Closed)

Created:
8 years, 8 months ago by vissi
Modified:
8 years, 8 months ago
CC:
native-client-reviews_googlegroups.com, Mark Seaborn
Base URL:
http://git.chromium.org/native_client/nacl-glibc.git@master
Visibility:
Public.

Description

removed epoll_create1 (EPOLL_CLOEXEC is not applicable to NaCl, as there is no possibility to fork); added recv and send to syscalls.list BUG= TEST= Committed: https://git.chromium.org/gitweb?p=native_client/nacl-glibc.git;a=commit;h=256e1ec

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M elf/Versions View 1 chunk +0 lines, -1 line 0 comments Download
M sysdeps/nacl/irt_syscalls.h View 1 chunk +0 lines, -1 line 0 comments Download
M sysdeps/nacl/irt_syscalls.c View 2 chunks +0 lines, -2 lines 0 comments Download
M sysdeps/nacl/syscalls.list View 1 chunk +2 lines, -0 lines 1 comment Download
M sysdeps/nacl/sysdep.h View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
vissi
Hi, I have fixed problem wrapping send and recv, removed and inapplicable call. Test for ...
8 years, 8 months ago (2012-04-16 11:18:15 UTC) #1
Evgeniy Stepanov
On 2012/04/16 11:18:15, vissi wrote: > Hi, > I have fixed problem wrapping send and ...
8 years, 8 months ago (2012-04-16 11:32:15 UTC) #2
pasko-google - do not use
On 2012/04/16 11:32:15, Evgeniy Stepanov wrote: > On 2012/04/16 11:18:15, vissi wrote: > > Hi, ...
8 years, 8 months ago (2012-04-16 17:32:39 UTC) #3
pasko-google - do not use
https://chromiumcodereview.appspot.com/10095010/diff/1/sysdeps/nacl/syscalls.list File sysdeps/nacl/syscalls.list (right): https://chromiumcodereview.appspot.com/10095010/diff/1/sysdeps/nacl/syscalls.list#newcode26 sysdeps/nacl/syscalls.list:26: send - send Ci:ibni __libc_send __recv recv funny copy-paste ...
8 years, 8 months ago (2012-04-16 17:46:03 UTC) #4
vissi
8 years, 8 months ago (2012-04-18 10:36:42 UTC) #5
On 2012/04/16 17:46:03, pasko wrote:
>
https://chromiumcodereview.appspot.com/10095010/diff/1/sysdeps/nacl/syscalls....
> File sysdeps/nacl/syscalls.list (right):
> 
>
https://chromiumcodereview.appspot.com/10095010/diff/1/sysdeps/nacl/syscalls....
> sysdeps/nacl/syscalls.list:26: send		-	send		Ci:ibni	__libc_send	__recv recv
> funny copy-paste bug

https://chromiumcodereview.appspot.com/10095013/

Powered by Google App Engine
This is Rietveld 408576698