Issue 10095006: Fix handling of this in Array.prototype.concat method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10095006: Fix handling of this in Array.prototype.concat method. (Closed)

Created:
8 years, 8 months ago by Michael Starzinger

Modified:
8 years, 8 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix handling of this in Array.prototype.concat method. R=jkummerow@chromium.org BUG=v8:2080 TEST=test262/15.4.4.4-5-c-i-1 Committed: https://code.google.com/p/v8/source/detail?r=11323

Patch Set 1 #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	src/array.js	View		1 chunk	+5 lines, -1 line	1 comment	Download
	M	test/test262/test262.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 8 months ago (2012-04-16 08:08:56 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10095006/diff/1/src/array.js
File src/array.js (right):

https://chromiumcodereview.appspot.com/10095006/diff/1/src/array.js#newcode1
src/array.js:1: // Copyright 2010 the V8 project authors. All rights reserved.
2012

Expand Messages | Collapse Messages