[WebUI TaskManager] Fix JS check nits in chrome/browser/resources/task_manager.

chrome/browser/resources/task_manager/main.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @constructor */
 function TaskManager() { }
 
 cr.addSingletonGetter(TaskManager);
 
 var localStrings = new LocalStrings();
 
 TaskManager.prototype = {
   /**
    * Handle window close.
+   * @this
    */
-  onClose: function () {
+  onClose: function() {
     if (!this.disabled_) {
       this.disabled_ = true;
       commands.disableTaskManager();
     }
   },
 
   /**
    * Handles selection changes.
    * This is also called when data of tasks are refreshed, even if selection
    * has not been changed.
+   * @this
    */
-  onSelectionChange: function () {
+  onSelectionChange: function() {
     var sm = this.selectionModel_;
     var dm = this.dataModel_;
     var selectedIndexes = sm.selectedIndexes;
     var is_end_process_enabled = true;
     if (selectedIndexes.length == 0)
       is_end_process_enabled = false;
     for (var i = 0; i < selectedIndexes.length; i++) {
       var index = selectedIndexes[i];
       var task = dm.item(index);
       if (task['type'] == 'BROWSER')
         is_end_process_enabled = false;
     }
     if (this.is_end_process_enabled_ != is_end_process_enabled) {
       if (is_end_process_enabled)
-        $('kill-process').removeAttribute("disabled");
+        $('kill-process').removeAttribute('disabled');
       else
-        $('kill-process').setAttribute("disabled", "true");
+        $('kill-process').setAttribute('disabled', 'true');
 
       this.is_end_process_enabled_ = is_end_process_enabled;
     }
   },
 
   /**
    * Closes taskmanager dialog.
    * After this function is called, onClose() will be called.
+   * @this
    */
-  close: function () {
+  close: function() {
     window.close();
   },
 
   /**
    * Sends commands to kill selected processes.
+   * @this
    */
-  killSelectedProcesses: function () {
+  killSelectedProcesses: function() {
     var selectedIndexes = this.selectionModel_.selectedIndexes;
     var dm = this.dataModel_;
     var uniqueIds = [];
     for (var i = 0; i < selectedIndexes.length; i++) {
       var index = selectedIndexes[i];
       var task = dm.item(index);
       uniqueIds.push(task['uniqueId'][0]);
     }
 
     commands.killSelectedProcesses(uniqueIds);
   },
 
   /**
    * Initializes taskmanager.
+   * @this
    */
-  initialize: function (dialogDom, opt) {
+  initialize: function(dialogDom, opt) {
     if (!dialogDom) {
       console.log('ERROR: dialogDom is not defined.');
       return;
     }
 
     measureTime.startInterval('Load.DOM');
 
     this.opt_ = opt;
 
     this.initialized_ = true;
 
     this.elementsCache_ = {};
     this.dialogDom_ = dialogDom;
     this.document_ = dialogDom.ownerDocument;
 
     this.localized_column_ = [];
     for (var i = 0; i < DEFAULT_COLUMNS.length; i++) {
       var column_label_id = DEFAULT_COLUMNS[i][1];
       var localized_label = localStrings.getString(column_label_id);
       // Falls back to raw column_label_id if localized string is not defined.
-      if (localized_label == "")
+      if (localized_label == '')
         localized_label = column_label_id;
 
       this.localized_column_[i] = localized_label;
     }
 
     this.initElements_();
     this.initColumnModel_();
     this.selectionModel_ = new cr.ui.ListSelectionModel();
     this.dataModel_ = new cr.ui.ArrayDataModel([]);
 
@@ skipping 38 matching lines @@
     measureTime.recordInterval('Load.DOM');
     measureTime.recordInterval('Load.Total');
 
     loadDelayedIncludes(this);
   },
 
   /**
    * Initializes the visibilities and handlers of the elements.
    * This method is called by initialize().
    * @private
+   * @this
    */
   initElements_: function() {
     // <if expr="pp_ifdef('chromeos')">
     // The 'close-window' element exists only on ChromeOS.
     // This <if ... /if> section is removed while flattening HTML if chrome is
     // built as Desktop Chrome.
     if (!this.opt_['isShowCloseButton'])
       $('close-window').style.display = 'none';
     $('close-window').addEventListener('click', this.close.bind(this));
     // </if>
 
     $('kill-process').addEventListener('click',
                                        this.killSelectedProcesses.bind(this));
     $('about-memory-link').addEventListener('click', commands.openAboutMemory);
   },
 
   /**
    * Additional initialization of taskmanager. This function is called when
    * the loading of delayed scripts finished.
+   * @this
    */
   delayedInitialize: function() {
     this.initColumnMenu_();
     this.initTableMenu_();
 
     var dm = this.dataModel_;
     for (var i = 0; i < dm.length; i++) {
       var processId = dm.item(i)['processId'][0];
       for (var j = 0; j < DEFAULT_COLUMNS.length; j++) {
         var columnId = DEFAULT_COLUMNS[j][0];
@@ skipping 12 matching lines @@
             cr.ui.contextMenuHandler.setContextMenu(label,
                                                     this.tableContextMenu_);
         }
       }
     }
 
     this.isFinishedInitDelayed_ = true;
     this.table_.redraw();
   },
 
-  initColumnModel_: function () {
+  initColumnModel_: function() {
     var table_columns = new Array();
     for (var i = 0; i < DEFAULT_COLUMNS.length; i++) {
       var column = DEFAULT_COLUMNS[i];
       var columnId = column[0];
       if (!isColumnEnabled(columnId))
         continue;
 
       table_columns.push(new cr.ui.table.TableColumn(columnId,
                                                      this.localized_column_[i],
                                                      column[2]));
     }
 
     for (var i = 0; i < table_columns.length; i++) {
       table_columns[i].renderFunction = this.renderColumn_.bind(this);
     }
 
     this.columnModel_ = new cr.ui.table.TableColumnModel(table_columns);
   },
 
-  initColumnMenu_: function () {
+  initColumnMenu_: function() {
     this.column_menu_commands_ = [];
 
     this.commandsElement_ = this.document_.createElement('commands');
     this.document_.body.appendChild(this.commandsElement_);
 
     this.columnSelectContextMenu_ = this.document_.createElement('menu');
     for (var i = 0; i < DEFAULT_COLUMNS.length; i++) {
       var column = DEFAULT_COLUMNS[i];
 
       // Creates command element to receive event.
       var command = this.document_.createElement('command');
       command.id = COMMAND_CONTEXTMENU_COLUMN_PREFIX + '-' + column[0];
       cr.ui.Command.decorate(command);
       this.column_menu_commands_[command.id] = command;
       this.commandsElement_.appendChild(command);
 
       // Creates menuitem element.
       var item = this.document_.createElement('menuitem');
       item.command = command;
       command.menuitem = item;
       item.textContent = this.localized_column_[i];
       if (isColumnEnabled(column[0]))
-        item.setAttributeNode(this.document_.createAttribute("checked"));
+        item.setAttributeNode(this.document_.createAttribute('checked'));
       this.columnSelectContextMenu_.appendChild(item);
     }
 
     this.document_.body.appendChild(this.columnSelectContextMenu_);
     cr.ui.Menu.decorate(this.columnSelectContextMenu_);
 
     cr.ui.contextMenuHandler.setContextMenu(this.table_.header,
                                             this.columnSelectContextMenu_);
     cr.ui.contextMenuHandler.setContextMenu(this.table_.list,
                                             this.columnSelectContextMenu_);
 
     this.document_.addEventListener('command', this.onCommand_.bind(this));
     this.document_.addEventListener('canExecute',
                                     this.onCommandCanExecute_.bind(this));
   },
 
-  initTableMenu_: function () {
+  initTableMenu_: function() {
     this.table_menu_commands_ = [];
     this.tableContextMenu_ = this.document_.createElement('menu');
 
-    var addMenuItem = function (tm, command_id, string_id, default_label) {
+    var addMenuItem = function(tm, command_id, string_id, default_label) {
       // Creates command element to receive event.
       var command = tm.document_.createElement('command');
       command.id = COMMAND_CONTEXTMENU_TABLE_PREFIX + '-' + command_id;
       cr.ui.Command.decorate(command);
       tm.table_menu_commands_[command.id] = command;
       tm.commandsElement_.appendChild(command);
 
       // Creates menuitem element.
       var item = tm.document_.createElement('menuitem');
       item.command = command;
       command.menuitem = item;
       var localized_label = localStrings.getString(string_id);
       item.textContent = localized_label || default_label;
       tm.tableContextMenu_.appendChild(item);
     };
 
-    addMenuItem(this, 'inspect', 'inspect', "Inspect");
-    addMenuItem(this, 'activate', 'activate', "Activate");
+    addMenuItem(this, 'inspect', 'inspect', 'Inspect');
+    addMenuItem(this, 'activate', 'activate', 'Activate');
 
     this.document_.body.appendChild(this.tableContextMenu_);
     cr.ui.Menu.decorate(this.tableContextMenu_);
   },
 
-  initTable_: function () {
+  initTable_: function() {
     if (!this.dataModel_ || !this.selectionModel_ || !this.columnModel_) {
       console.log('ERROR: some models are not defined.');
       return;
     }
 
     this.table_ = this.dialogDom_.querySelector('.detail-table');
     cr.ui.Table.decorate(this.table_);
 
     this.table_.dataModel = this.dataModel_;
     this.table_.selectionModel = this.selectionModel_;
     this.table_.columnModel = this.columnModel_;
 
     // Expands height of row when a process has some tasks.
     this.table_.fixedHeight = false;
 
     this.table_.list.addEventListener('contextmenu',
                                       this.onTableContextMenuOpened_.bind(this),
                                       true);
 
     // Sets custom row render function.
     this.table_.setRenderFunction(this.getRow_.bind(this));
   },
 
   /**
    * Returns a list item element of the list. This method trys to reuse the
    * cached element, or creates a new element.
+   * @return {cr.ui.ListItem}  list item element which contains the given data.
    * @private
+   * @this
    */
   getRow_: function(data, table) {
     // Trys to reuse the cached row;
     var listItemElement = this.renderRowFromCache_(data, table);
     if (listItemElement)
       return listItemElement;
 
     // Initializes the cache.
     var pid = data['processId'][0];
     this.elementsCache_[pid] = {
-      listItem:null,
-      cell:[],
-      icon:[],
-      columns:{}
+      listItem: null,
+      cell: [],
+      icon: [],
+      columns: {}
     };
 
     // Create new row.
     return this.renderRow_(data, table);
   },
 
   /**
    * Returns a list item element with re-using the previous cached element, or
    * returns null if failed.
+   * @return {cr.ui.ListItem} cached un-used element to be reused.
    * @private
+   * @this
    */
   renderRowFromCache_: function(data, table) {
     var pid = data['processId'][0];
 
     // Checks whether the cache exists or not.
     var cache = this.elementsCache_[pid];
     if (!cache)
       return null;
 
     var listItemElement = cache.listItem;
@@ skipping 44 matching lines @@
     listItemElement.data = data;
 
     // Removes 'selected' and 'lead' attributes.
     listItemElement.removeAttribute('selected');
     listItemElement.removeAttribute('lead');
 
     return listItemElement;
   },
 
   /**
-   * Create a new list item element and returns it.
+   * Create a new list item element.
+   * @return {cr.ui.ListItem} created new list item element.
    * @private
+   * @this
    */
   renderRow_: function(data, table) {
     var pid = data['processId'][0];
     var cm = table.columnModel;
     var listItem = new cr.ui.ListItem({label: ''});
 
     listItem.className = 'table-row';
     if (this.opt_.isBackgroundMode && data.isBackgroundResource)
       listItem.className += ' table-background-row';
 
@@ skipping 21 matching lines @@
     // childlen.
     this.elementsCache_[pid].listItem = listItem;
     this.elementsCache_[pid].cachedColumnSize = cm.size;
     this.elementsCache_[pid].cachedChildSize = data['uniqueId'].length;
 
     return listItem;
   },
 
   /**
    * Create a new element of the cell.
+   * @return {HTMLDIVElement} created cell
    * @private
+   * @this
    */
   renderColumn_: function(entry, columnId, table) {
     var container = this.document_.createElement('div');
     container.className = 'detail-container-' + columnId;
     var pid = entry['processId'][0];
 
     var cache = [];
     var cacheIcon = [];
 
     if (entry && entry[columnId]) {
@@ skipping 44 matching lines @@
       this.elementsCache_[pid].columns[columnId] = cache;
       if (columnId == 'title')
         this.elementsCache_[pid].icon = cacheIcon;
     }
     return container;
   },
 
   /**
    * Updates the task list with the supplied task.
    * @private
+   * @this
    */
   processTaskChange: function(task) {
     var dm = this.dataModel_;
     var sm = this.selectionModel_;
     if (!dm || !sm) return;
 
     this.table_.list.startBatchUpdates();
     sm.beginChange();
 
     var type = task.type;
@@ skipping 36 matching lines @@
       if (pids.indexOf(pid) == -1)
         delete this.elementsCache_[pid];
     }
 
     sm.endChange();
     this.table_.list.endBatchUpdates();
   },
 
   /**
    * Respond to a command being executed.
+   * @this
    */
   onCommand_: function(event) {
     var command = event.command;
     var command_id = command.id.split('-', 2);
 
     var main_command = command_id[0];
     var sub_command = command_id[1];
 
     if (main_command == COMMAND_CONTEXTMENU_COLUMN_PREFIX) {
       this.onColumnContextMenu_(sub_command, command);
@@ skipping 12 matching lines @@
     }
   },
 
   onCommandCanExecute_: function(event) {
     event.canExecute = true;
   },
 
   /**
    * Store resourceIndex of target resource of context menu, because resource
    * will be replaced when it is refreshed.
+   * @this
    */
-  onTableContextMenuOpened_: function (e) {
+  onTableContextMenuOpened_: function(e) {
     if (!this.isFinishedInitDelayed_)
       return;
 
     var mc = this.table_menu_commands_;
     var inspect_menuitem =
         mc[COMMAND_CONTEXTMENU_TABLE_PREFIX + '-inspect'].menuitem;
     var activate_menuitem =
         mc[COMMAND_CONTEXTMENU_TABLE_PREFIX + '-activate'].menuitem;
 
     // Disabled by default.
     inspect_menuitem.disabled = true;
     activate_menuitem.disabled = true;
 
     var target = e.target;
-    for (; ; target = target.parentNode) {
+    for (;; target = target.parentNode) {
       if (!target) return;
       var classes = target.classList;
       if (classes &&
           Array.prototype.indexOf.call(classes, 'detail-title') != -1) break;
     }
 
     var index_in_group = target.index_in_group;
 
     // Sets the uniqueId for current target page under the mouse corsor.
     this.currentContextMenuTarget_ = target.data['uniqueId'][index_in_group];
@@ skipping 20 matching lines @@
         checkedItemCount++;
     }
     if (checkedItemCount == 1 && checked)
       return;
 
     // Toggles the visibility of the column.
     var newChecked = !checked;
     menuitem.checked = newChecked;
     setColumnEnabled(columnId, newChecked);
 
-    this.initColumnModel_()
+    this.initColumnModel_();
     this.table_.columnModel = this.columnModel_;
     this.table_.redraw();
   },
 };
 
 // |taskmanager| has been declared in preload.js.
 taskmanager = TaskManager.getInstance();
 
 function init() {
   var params = parseQueryParams(window.location);
   var opt = {};
   opt['isBackgroundMode'] = params.background;
   opt['isShowCloseButton'] = params.showclose;
   taskmanager.initialize(document.body, opt);
 }
 
 document.addEventListener('DOMContentLoaded', init);
 document.addEventListener('Close', taskmanager.onClose.bind(taskmanager));