Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Unified Diff: chrome/browser/chromeos/extensions/file_manager_util.h

Issue 10094012: Made File Manager respect the user-selected launch type (tab/pinned tab/window/fullscreen) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_manager_util.h
diff --git a/chrome/browser/chromeos/extensions/file_manager_util.h b/chrome/browser/chromeos/extensions/file_manager_util.h
index 9645b8afcda928bc13eb6b133b43d3ac62246d1e..c897724ad3e9104676c6344227ead1dc1c71ece0 100644
--- a/chrome/browser/chromeos/extensions/file_manager_util.h
+++ b/chrome/browser/chromeos/extensions/file_manager_util.h
@@ -54,25 +54,31 @@ GURL GetFileBrowserUrlWithParams(
// Get file dialog title string from its type.
string16 GetTitleFromType(SelectFileDialog::Type type);
-// Opens file browser UI on its own tab on drive location defined with
-// |dir|. Automatically closes this tab on |dir| unmount.
-void ViewRemovableDrive(const FilePath& dir);
+// Shows a freshly mounted removable drive.
+// If there is another File Browser instance open this call does nothing. The
+// mount event will cause file_manager.js to show the new drive in the roots
dgozman 2012/04/16 15:28:34 I'd say "in left panel" instead.
+// list, and that is all we want.
+// If there is no File Browser open, this call opens a new one pointing to
+// |path|. In this case the tab will automatically close on |path| unmount.
+void ViewRemovableDrive(const FilePath& path);
// Opens file browser UI in its own tab on file system location defined with
// |dir|.
void ViewFolder(const FilePath& dir);
-// Opens file in the browser.
-// TODO(kaznacheev): remove the obsolete enqueue parameter.
-void ViewFile(const FilePath& full_path, bool enqueue);
+// Opens file with the default File Browser handler.
+void ViewFile(const FilePath& path);
+
+// Opens file browser on the folder containing the file, with the file selected.
+void ShowFileInFolder(const FilePath& path);
// Tries to open |file| directly in the browser. Returns false if the browser
// can't directly handle this type of file.
-bool TryViewingFile(const FilePath& file);
+bool TryViewingFile(Profile* profile, const FilePath& path);
-void InstallCRX(Profile* profile, const FilePath& full_path);
+void InstallCRX(Profile* profile, const FilePath& path);
-bool ShouldBeOpenedWithPdfPlugin(const char* file_extension);
+bool ShouldBeOpenedWithPdfPlugin(Profile* profile, const char* file_extension);
// Converts the vector of progress status to their JSON (Value) form.
base::ListValue* ProgressStatusVectorToListValue(
« no previous file with comments | « chrome/browser/chromeos/extensions/file_handler_util.h ('k') | chrome/browser/chromeos/extensions/file_manager_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698