Issue 10094012: Made File Manager respect the user-selected launch type (tab/pinned tab/window/fullscreen)

Issue 10094012: Made File Manager respect the user-selected launch type (tab/pinned tab/window/fullscreen) (Closed)

Created:
8 years, 8 months ago by Vladislav Kaznacheev

Modified:
8 years, 8 months ago

Reviewers:
dgozman

CC:
chromium-reviews, asanka, nkostylev+watch_chromium.org, feature-media-reviews_chromium.org, achuith+watch_chromium.org, mihaip+watch_chromium.org, Randy Smith (Not in Mondays), Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews), stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Made File Manager respect the user-selected launch type (tab/pinned tab/window/fullscreen)" BUG=chromium-os:27884 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132564

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments #

Total comments: 1

Patch Set 3 : Polished a comment #

Patch Set 4 : Fixed a test #

Patch Set 5 : Moved changes requiring external OWNERs approval to another patch #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+160 lines, -152 lines)			Patch
M	chrome/browser/chromeos/extensions/file_browser_private_api.cc	View	1 2 3 4	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_handler_util.h	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager_util.h	View	1 2 3 4	1 chunk	+16 lines, -9 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_manager_util.cc	View	1 2 3 4	12 chunks	+120 lines, -77 lines	0 comments	Download
M	chrome/browser/chromeos/media/media_player.h	View		2 chunks	+1 line, -6 lines	0 comments	Download
M	chrome/browser/chromeos/media/media_player.cc	View		3 chunks	+2 lines, -16 lines	0 comments	Download
M	chrome/browser/chromeos/media/media_player_browsertest.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/media/media_player_extension_api.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/platform_util_chromeos.cc	View	1 2 3 4	2 chunks	+1 line, -31 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager.js	View	1 2 3 4	5 chunks	+13 lines, -8 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

dgozman

Don't you need an owner review for some files? https://chromiumcodereview.appspot.com/10094012/diff/1/chrome/browser/chromeos/extensions/file_manager_util.cc File chrome/browser/chromeos/extensions/file_manager_util.cc (right): https://chromiumcodereview.appspot.com/10094012/diff/1/chrome/browser/chromeos/extensions/file_manager_util.cc#newcode393 chrome/browser/chromeos/extensions/file_manager_util.cc:393: ...

8 years, 8 months ago (2012-04-16 14:48:32 UTC) #1

Vladislav Kaznacheev

I do need OWNERs LGTM for one of the files, will ask for it when ...

8 years, 8 months ago (2012-04-16 15:23:44 UTC) #2

dgozman

LGTM https://chromiumcodereview.appspot.com/10094012/diff/3001/chrome/browser/chromeos/extensions/file_manager_util.h File chrome/browser/chromeos/extensions/file_manager_util.h (right): https://chromiumcodereview.appspot.com/10094012/diff/3001/chrome/browser/chromeos/extensions/file_manager_util.h#newcode59 chrome/browser/chromeos/extensions/file_manager_util.h:59: // mount event will cause file_manager.js to show ...

8 years, 8 months ago (2012-04-16 15:28:34 UTC) #3

Vladislav Kaznacheev

Hi Nikita, Please review a one-line change to chrome/browser/ui/webui/chromeos/active_downloads_ui.cc. I removed an obsolete parameter. Best ...

8 years, 8 months ago (2012-04-16 15:35:11 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/10094012/8001

8 years, 8 months ago (2012-04-17 09:32:52 UTC) #5

Change committed as 132564

Expand Messages | Collapse Messages