Issue 10094011: Add method for resolving SnapshotObjectId by given object

Issue 10094011: Add method for resolving SnapshotObjectId by given object (Closed)

Created:
8 years, 8 months ago by yurys

Modified:
8 years, 8 months ago

Reviewers:
alexeif, mnaganov (inactive), loislo

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Add method for resolving SnapshotObjectId by given object Committed: https://code.google.com/p/v8/source/detail?r=11339

Patch Set 2 : #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -1 line)			Patch
M	include/v8-profiler.h	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/api.cc	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/heap-profiler.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/heap-profiler.cc	View	1	1 chunk	+9 lines, -0 lines	2 comments	Download
M	src/profile-generator.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/profile-generator.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	test/cctest/test-heap-profiler.cc	View	1	1 chunk	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

yurys

http://codereview.chromium.org/10094011/diff/1/src/profile-generator.cc File src/profile-generator.cc (left): http://codereview.chromium.org/10094011/diff/1/src/profile-generator.cc#oldcode1369 src/profile-generator.cc:1369: entry_info.accessed = true; HeapObjectsMap::FindEntry is only called by HeapSnapshotsCollection::FindHeapObjectById ...

8 years, 8 months ago (2012-04-16 13:04:38 UTC) #2

mnaganov (inactive)

http://codereview.chromium.org/10094011/diff/6001/src/heap-profiler.cc File src/heap-profiler.cc (right): http://codereview.chromium.org/10094011/diff/6001/src/heap-profiler.cc#newcode197 src/heap-profiler.cc:197: return profiler->snapshots_->FindObjectId(HeapObject::cast(*obj) ->address()); nit: space before the last "->"

8 years, 8 months ago (2012-04-16 20:15:56 UTC) #5

yurys

8 years, 8 months ago (2012-04-17 09:01:14 UTC) #6

http://codereview.chromium.org/10094011/diff/6001/src/heap-profiler.cc
File src/heap-profiler.cc (right):

http://codereview.chromium.org/10094011/diff/6001/src/heap-profiler.cc#newcod...
src/heap-profiler.cc:197: return
profiler->snapshots_->FindObjectId(HeapObject::cast(*obj) ->address());
On 2012/04/16 20:15:56, Mikhail Naganov (Chromium) wrote:
> nit: space before the last "->"

Fixed in https://code.google.com/p/v8/source/detail?r=11346

Expand Messages | Collapse Messages