Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 10093007: MIPS: Do the qNaN fixup at de-serialization time. (Closed)

Created:
8 years, 8 months ago by Paul Lind
Modified:
8 years, 8 months ago
Reviewers:
kisg, Erik Corry, kalmard, danno
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Do the qNaN fixup at de-serialization time. Too many edge cases trying to store mips qNaN pattern in ia32-generated snapshot. Simpler to restore it on target, where it will always be correct. This does unify the two NaN's that are currently stored in the Heap to the single roots array NaN value. BUG= TEST=

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M src/isolate.cc View 1 chunk +3 lines, -0 lines 1 comment Download
M src/mips/assembler-mips.cc View 1 chunk +5 lines, -12 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/runtime.js View 1 chunk +1 line, -1 line 0 comments Download
M src/serialize.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paul Lind
8 years, 8 months ago (2012-04-16 04:27:31 UTC) #1
Erik Corry
Is there a file missing from this CL? I can't see where the NaN is ...
8 years, 8 months ago (2012-04-17 08:21:15 UTC) #2
Paul Lind
It is line 1845 in isolate.cc: if(des != NULL) Assembler::QuietNaN(heap_.nan_value()); Since the runtime NaN was ...
8 years, 8 months ago (2012-04-17 14:38:14 UTC) #3
Erik Corry
8 years, 8 months ago (2012-04-20 14:55:25 UTC) #4
LGTM

https://chromiumcodereview.appspot.com/10093007/diff/1/src/isolate.cc
File src/isolate.cc (right):

https://chromiumcodereview.appspot.com/10093007/diff/1/src/isolate.cc#newcode...
src/isolate.cc:1846: if(des != NULL) Assembler::QuietNaN(heap_.nan_value());
Missing space after 'if'

Powered by Google App Engine
This is Rietveld 408576698