Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3719)

Unified Diff: chrome/browser/browsing_data_server_bound_cert_helper.cc

Issue 10092013: Display third party cookies and site data counts in the WebsiteSettings UI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: "Fix CannedBrowsingDataDatabaseHelperTest.*" Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data_server_bound_cert_helper.cc
diff --git a/chrome/browser/browsing_data_server_bound_cert_helper.cc b/chrome/browser/browsing_data_server_bound_cert_helper.cc
index 7308724aa8ba4835f243867942081732b9c38116..dc56bb350a106604b4d74554ed0ed949cacec5c2 100644
--- a/chrome/browser/browsing_data_server_bound_cert_helper.cc
+++ b/chrome/browser/browsing_data_server_bound_cert_helper.cc
@@ -37,6 +37,10 @@ class BrowsingDataServerBoundCertHelperImpl
// Delete a single cert. This must be called in IO thread.
void DeleteOnIOThread(const std::string& server_id);
+ // Access to |server_bound_cert_list_| is triggered indirectly via the UI
+ // thread and guarded by |is_fetching_|. This means |server_bound_cert_list_|
+ // is only accessed while |is_fetching_| is true. The flag |is_fetching_| is
+ // only accessed on the UI thread.
net::ServerBoundCertStore::ServerBoundCertList server_bound_cert_list_;
// Indicates whether or not we're currently fetching information:
@@ -146,6 +150,7 @@ CannedBrowsingDataServerBoundCertHelper::Clone() {
void CannedBrowsingDataServerBoundCertHelper::AddServerBoundCert(
const net::ServerBoundCertStore::ServerBoundCert& server_bound_cert) {
+ DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
server_bound_cert_map_[server_bound_cert.server_identifier()] =
server_bound_cert;
}
@@ -159,6 +164,7 @@ bool CannedBrowsingDataServerBoundCertHelper::empty() const {
}
size_t CannedBrowsingDataServerBoundCertHelper::GetCertCount() const {
+ DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
return server_bound_cert_map_.size();
}
« no previous file with comments | « chrome/browser/browsing_data_local_storage_helper.cc ('k') | chrome/browser/content_settings/local_shared_objects_container.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698