Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1303)

Unified Diff: chrome/browser/browsing_data_file_system_helper.h

Issue 10092013: Display third party cookies and site data counts in the WebsiteSettings UI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: "Fix CannedBrowsingDataDatabaseHelperTest.*" Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data_file_system_helper.h
diff --git a/chrome/browser/browsing_data_file_system_helper.h b/chrome/browser/browsing_data_file_system_helper.h
index 70ca66746e969a4081a126cdc4d6564a484cee42..c586b3809b87e551c4ac4a065f90d2bc416b13f2 100644
--- a/chrome/browser/browsing_data_file_system_helper.h
+++ b/chrome/browser/browsing_data_file_system_helper.h
@@ -133,6 +133,11 @@ class CannedBrowsingDataFileSystemHelper
// Returns the number of currently stored filesystems.
size_t GetFileSystemCount() const;
+ // Returns the current list of filesystems.
+ const std::list<FileSystemInfo>& GetFileSystemInfo() {
+ return file_system_info_;
+ }
+
// BrowsingDataFileSystemHelper implementation.
virtual void StartFetching(const base::Callback<
void(const std::list<FileSystemInfo>&)>& callback) OVERRIDE;
@@ -152,8 +157,11 @@ class CannedBrowsingDataFileSystemHelper
// must be called on the UI thread.
void NotifyOnUIThread();
- // Holds the current list of file systems returned to the client after
- // StartFetching is called.
+ // Holds the current list of filesystems returned to the client. Access to
+ // |file_system_info_| is triggered indirectly via the UI thread and guarded
+ // by |is_fetching_|. This means |file_system_info_| is only accessed while
+ // |is_fetching_| is true. The flag |is_fetching_| is only accessed on the UI
+ // thread.
std::list<FileSystemInfo> file_system_info_;
// The callback passed in at the beginning of the StartFetching workflow so
« no previous file with comments | « chrome/browser/browsing_data_database_helper_unittest.cc ('k') | chrome/browser/browsing_data_file_system_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698