Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: chrome/browser/browsing_data_indexed_db_helper.cc

Issue 10092013: Display third party cookies and site data counts in the WebsiteSettings UI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: " Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data_indexed_db_helper.cc
diff --git a/chrome/browser/browsing_data_indexed_db_helper.cc b/chrome/browser/browsing_data_indexed_db_helper.cc
index c12322542abb7d4a51b91c55ffdf9af59a6c1123..1d25a839c52987f9229809ae5af905c90f4ecbdf 100644
--- a/chrome/browser/browsing_data_indexed_db_helper.cc
+++ b/chrome/browser/browsing_data_indexed_db_helper.cc
@@ -151,24 +151,29 @@ BrowsingDataIndexedDBHelper* BrowsingDataIndexedDBHelper::Create(
}
CannedBrowsingDataIndexedDBHelper::
-PendingIndexedDBInfo::PendingIndexedDBInfo() {
-}
-
-CannedBrowsingDataIndexedDBHelper::
PendingIndexedDBInfo::PendingIndexedDBInfo(const GURL& origin,
- const string16& description)
+ const string16& name)
: origin(origin),
- description(description) {
+ name(name) {
}
CannedBrowsingDataIndexedDBHelper::
PendingIndexedDBInfo::~PendingIndexedDBInfo() {
}
+bool CannedBrowsingDataIndexedDBHelper::PendingIndexedDBInfo::operator<(
+ const PendingIndexedDBInfo& other) const {
+ if (origin == other.origin)
+ return name < other.name;
+ return origin < other.origin;
+}
+
CannedBrowsingDataIndexedDBHelper::CannedBrowsingDataIndexedDBHelper()
: is_fetching_(false) {
}
+CannedBrowsingDataIndexedDBHelper::~CannedBrowsingDataIndexedDBHelper() {}
+
CannedBrowsingDataIndexedDBHelper* CannedBrowsingDataIndexedDBHelper::Clone() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
CannedBrowsingDataIndexedDBHelper* clone =
@@ -181,12 +186,12 @@ CannedBrowsingDataIndexedDBHelper* CannedBrowsingDataIndexedDBHelper::Clone() {
}
void CannedBrowsingDataIndexedDBHelper::AddIndexedDB(
- const GURL& origin, const string16& description) {
+ const GURL& origin, const string16& name) {
Bernhard Bauer 2012/05/11 13:05:00 This doesn't match the declared signature anymore.
markusheintz_ 2012/05/14 11:00:54 Done.
if (!BrowsingDataHelper::HasValidScheme(origin))
return; // Non-websafe state is not considered browsing data.
base::AutoLock auto_lock(lock_);
- pending_indexed_db_info_.push_back(PendingIndexedDBInfo(origin, description));
+ pending_indexed_db_info_.insert(PendingIndexedDBInfo(origin, name));
}
void CannedBrowsingDataIndexedDBHelper::Reset() {
@@ -201,9 +206,16 @@ bool CannedBrowsingDataIndexedDBHelper::empty() const {
}
size_t CannedBrowsingDataIndexedDBHelper::GetIndexedDBCount() const {
+ base::AutoLock auto_lock(lock_);
return pending_indexed_db_info_.size();
}
+const std::set<CannedBrowsingDataIndexedDBHelper::PendingIndexedDBInfo>&
+CannedBrowsingDataIndexedDBHelper::GetIndexedDBInfo() const {
+ base::AutoLock auto_lock(lock_);
+ return pending_indexed_db_info_;
+}
+
void CannedBrowsingDataIndexedDBHelper::StartFetching(
const base::Callback<void(const std::list<IndexedDBInfo>&)>& callback) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
@@ -219,35 +231,21 @@ void CannedBrowsingDataIndexedDBHelper::StartFetching(
this));
}
-CannedBrowsingDataIndexedDBHelper::~CannedBrowsingDataIndexedDBHelper() {}
-
void CannedBrowsingDataIndexedDBHelper::ConvertPendingInfoInWebKitThread() {
base::AutoLock auto_lock(lock_);
- for (std::list<PendingIndexedDBInfo>::const_iterator
+ indexed_db_info_.clear();
+ for (std::set<PendingIndexedDBInfo>::const_iterator
info = pending_indexed_db_info_.begin();
info != pending_indexed_db_info_.end(); ++info) {
- bool duplicate = false;
- for (std::list<IndexedDBInfo>::iterator
- indexed_db = indexed_db_info_.begin();
- indexed_db != indexed_db_info_.end(); ++indexed_db) {
- if (indexed_db->origin == info->origin) {
- duplicate = true;
- break;
- }
- }
- if (duplicate)
- continue;
-
indexed_db_info_.push_back(IndexedDBInfo(
info->origin,
0,
base::Time()));
}
- pending_indexed_db_info_.clear();
- BrowserThread::PostTask(
- BrowserThread::UI, FROM_HERE,
- base::Bind(&CannedBrowsingDataIndexedDBHelper::NotifyInUIThread, this));
+ BrowserThread::PostTask(
+ BrowserThread::UI, FROM_HERE,
+ base::Bind(&CannedBrowsingDataIndexedDBHelper::NotifyInUIThread, this));
}
void CannedBrowsingDataIndexedDBHelper::NotifyInUIThread() {
« no previous file with comments | « chrome/browser/browsing_data_indexed_db_helper.h ('k') | chrome/browser/browsing_data_local_storage_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698