Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: chrome/browser/browsing_data_local_storage_helper.cc

Issue 10092013: Display third party cookies and site data counts in the WebsiteSettings UI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: " Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data_local_storage_helper.cc
diff --git a/chrome/browser/browsing_data_local_storage_helper.cc b/chrome/browser/browsing_data_local_storage_helper.cc
index 446fa95750f3ca3433563e68b3d1222dca76a103..58838aaa964cd1ccd530da0a8771d58fa43e5b21 100644
--- a/chrome/browser/browsing_data_local_storage_helper.cc
+++ b/chrome/browser/browsing_data_local_storage_helper.cc
@@ -23,11 +23,6 @@ using content::BrowserThread;
using content::DOMStorageContext;
using WebKit::WebSecurityOrigin;
-BrowsingDataLocalStorageHelper::LocalStorageInfo::LocalStorageInfo()
- : port(0),
- size(0) {
-}
-
BrowsingDataLocalStorageHelper::LocalStorageInfo::LocalStorageInfo(
const std::string& protocol,
const std::string& host,
@@ -168,6 +163,11 @@ size_t CannedBrowsingDataLocalStorageHelper::GetLocalStorageCount() const {
return pending_local_storage_info_.size();
}
+const std::set<GURL>&
+CannedBrowsingDataLocalStorageHelper::GetLocalStorageInfo() const {
+ return pending_local_storage_info_;
+}
+
void CannedBrowsingDataLocalStorageHelper::StartFetching(
const base::Callback<void(const std::list<LocalStorageInfo>&)>& callback) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
@@ -189,23 +189,12 @@ CannedBrowsingDataLocalStorageHelper::~CannedBrowsingDataLocalStorageHelper() {}
void CannedBrowsingDataLocalStorageHelper::ConvertPendingInfo() {
for (std::set<GURL>::iterator info = pending_local_storage_info_.begin();
info != pending_local_storage_info_.end(); ++info) {
+ local_storage_info_.clear();
WebSecurityOrigin web_security_origin =
WebSecurityOrigin::createFromString(
UTF8ToUTF16(info->spec()));
std::string security_origin(web_security_origin.toString().utf8());
- bool duplicate = false;
- for (std::list<LocalStorageInfo>::iterator
- local_storage = local_storage_info_.begin();
- local_storage != local_storage_info_.end(); ++local_storage) {
- if (local_storage->origin == security_origin) {
- duplicate = true;
- break;
- }
- }
- if (duplicate)
- continue;
-
local_storage_info_.push_back(LocalStorageInfo(
web_security_origin.protocol().utf8(),
web_security_origin.host().utf8(),
@@ -217,7 +206,6 @@ void CannedBrowsingDataLocalStorageHelper::ConvertPendingInfo() {
0,
base::Time()));
}
- pending_local_storage_info_.clear();
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,

Powered by Google App Engine
This is Rietveld 408576698