Display third party cookies and site data counts in the WebsiteSettings UI.

chrome/browser/browsing_data_local_storage_helper.h

Index: chrome/browser/browsing_data_local_storage_helper.h
diff --git a/chrome/browser/browsing_data_local_storage_helper.h b/chrome/browser/browsing_data_local_storage_helper.h
index 6d32b0df79d5343f67b192d371c0d67daa9dd600..d6652b2b9c2c288e393ed72fed188babd9b4d765 100644
--- a/chrome/browser/browsing_data_local_storage_helper.h
+++ b/chrome/browser/browsing_data_local_storage_helper.h
@@ -35,7 +35,6 @@ class BrowsingDataLocalStorageHelper
  public:
   // Contains detailed information about local storage.
   struct LocalStorageInfo {
-    LocalStorageInfo();
     LocalStorageInfo(
         const std::string& protocol,
         const std::string& host,
@@ -124,6 +123,11 @@ class CannedBrowsingDataLocalStorageHelper
   // Returns the number of local storages currently stored.
   size_t GetLocalStorageCount() const;
 
+  // Returns the set of origins that use local storage.
+  const std::set<GURL>& pending_local_storage_info() const {

[bauerb at google, 2012/04/27 16:12:50]

Including this one, we now have five methods in this class which just delegate
to a set, and they have four different naming schemes (if we consider AddFoo()
and GetFooCount() to follow the same scheme). That makes me a sad panda :(

[markusheintz_, 2012/05/10 16:32:36]

The style guide recommend to user Unix hacker style for accessors:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Function_Names

But I really like to make you a happy Panda. So I converted this to the
GetLocalStorageInfo... naming scheme. The fact the pending_local_storage is
returned is an implementation detail. What the caller wants here is the current
list of local storage info objects. Therfor I name it GetLocalStorageInfo.

I really need to refactor the browsing data code. And I will do so soon :).

Hope that makes you a slightly less sad Panda. I'm also not yet happy.

+    return pending_local_storage_info_;
+  }
+
   // BrowsingDataLocalStorageHelper implementation.
   virtual void StartFetching(
       const base::Callback<void(const std::list<LocalStorageInfo>&)>& callback)