Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: lib/compiler/implementation/ssa/validate.dart

Issue 10091048: Fix remaining warnings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/ssa/optimize.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/validate.dart
diff --git a/lib/compiler/implementation/ssa/validate.dart b/lib/compiler/implementation/ssa/validate.dart
index 5851cad9ab52061191aeec7368fa9c355d379565..3786e6efa2984849928b482ad752c738c25cb8cf 100644
--- a/lib/compiler/implementation/ssa/validate.dart
+++ b/lib/compiler/implementation/ssa/validate.dart
@@ -6,9 +6,9 @@ class HValidator extends HInstructionVisitor {
bool isValid = true;
HGraph graph;
- void visitGraph(HGraph graph) {
- this.graph = graph;
- visitDominatorTree(graph);
+ void visitGraph(HGraph visitee) {
+ graph = visitee;
+ visitDominatorTree(visitee);
}
void markInvalid(String reason) {
@@ -121,7 +121,7 @@ class HValidator extends HInstructionVisitor {
void visitInstruction(HInstruction instruction) {
// Verifies that we are in the use list of our inputs.
- bool hasCorrectInputs(instruction) {
+ bool hasCorrectInputs() {
bool inBasicBlock = instruction.isInBasicBlock();
return everyInstruction(instruction.inputs, (input, count) {
if (inBasicBlock) {
@@ -133,7 +133,7 @@ class HValidator extends HInstructionVisitor {
}
// Verifies that all our uses have us in their inputs.
- bool hasCorrectUses(instruction) {
+ bool hasCorrectUses() {
if (!instruction.isInBasicBlock()) return true;
return everyInstruction(instruction.usedBy, (use, count) {
return countInstruction(use.inputs, instruction) == count;
@@ -143,10 +143,10 @@ class HValidator extends HInstructionVisitor {
if (instruction.block !== currentBlock) {
markInvalid("Instruction in wrong block");
}
- if (!hasCorrectInputs(instruction)) {
+ if (!hasCorrectInputs()) {
markInvalid("Incorrect inputs");
}
- if (!hasCorrectUses(instruction)) {
+ if (!hasCorrectUses()) {
markInvalid("Incorrect uses");
}
}
« no previous file with comments | « lib/compiler/implementation/ssa/optimize.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698