Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: lib/compiler/implementation/native_handler.dart

Issue 10091048: Fix remaining warnings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/native_emitter.dart ('k') | lib/compiler/implementation/resolver.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/native_handler.dart
diff --git a/lib/compiler/implementation/native_handler.dart b/lib/compiler/implementation/native_handler.dart
index 2c51c77178c7c129d02860acafe61fdcc8e63805..208df3a42bc552dfaf54ae0bb5a636932c012ad5 100644
--- a/lib/compiler/implementation/native_handler.dart
+++ b/lib/compiler/implementation/native_handler.dart
@@ -204,8 +204,9 @@ void handleSsaNative(SsaBuilder builder, Send node) {
if (element.name == const SourceString('typeName')
&& element.isGetter()
&& nativeEmitter.toNativeName(element.enclosingElement) == 'DOMType') {
- Element element = compiler.findHelper(const SourceString('getTypeNameOf'));
- HStatic method = new HStatic(element);
+ Element methodElement =
+ compiler.findHelper(const SourceString('getTypeNameOf'));
+ HStatic method = new HStatic(methodElement);
builder.add(method);
builder.push(new HInvokeStatic(Selector.INVOCATION_1,
<HInstruction>[method, builder.localsHandler.readThis()]));
@@ -312,9 +313,10 @@ void generateMethodWithPrototypeCheckForElement(Compiler compiler,
String methodName;
Namer namer = compiler.namer;
if (element.kind == ElementKind.FUNCTION) {
- FunctionParameters parameters = element.computeParameters(compiler);
+ FunctionParameters computedParameters =
+ element.computeParameters(compiler);
methodName = namer.instanceMethodName(
- element.getLibrary(), element.name, parameters.parameterCount);
+ element.getLibrary(), element.name, computedParameters.parameterCount);
} else if (element.kind == ElementKind.GETTER) {
methodName = namer.getterName(element.getLibrary(), element.name);
} else if (element.kind == ElementKind.SETTER) {
« no previous file with comments | « lib/compiler/implementation/native_emitter.dart ('k') | lib/compiler/implementation/resolver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698