Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1056)

Unified Diff: lib/compiler/implementation/native_emitter.dart

Issue 10091048: Fix remaining warnings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/compiler/implementation/native_handler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/native_emitter.dart
diff --git a/lib/compiler/implementation/native_emitter.dart b/lib/compiler/implementation/native_emitter.dart
index fe6da7866c6380b48da79fbb48e3ba683a52c9df..0b4dc09eccfd9658506273ce948e1e0c2142037d 100644
--- a/lib/compiler/implementation/native_emitter.dart
+++ b/lib/compiler/implementation/native_emitter.dart
@@ -206,8 +206,8 @@ class NativeEmitter {
}
classes.add(cls);
}
- for (final ClassElement cls in classesWithDynamicDispatch) {
- visit(cls);
+ for (final ClassElement classElement in classesWithDynamicDispatch) {
+ visit(classElement);
}
Collection<ClassElement> dispatchClasses = classes.filter(
@@ -239,11 +239,11 @@ class NativeEmitter {
// tag -> expression (a string or a variable)
Map<ClassElement, String> tagDefns = new Map<ClassElement, String>();
- String makeExpression(ClassElement cls) {
+ String makeExpression(ClassElement classElement) {
// Expression fragments for this set of cls keys.
List<String> expressions = <String>[];
// TODO: Remove if cls is abstract.
- List<String> subtags = [toNativeName(cls)];
+ List<String> subtags = [toNativeName(classElement)];
void walk(ClassElement cls) {
for (final ClassElement subclass in getDirectSubclasses(cls)) {
ClassElement tag = subclass;
@@ -264,7 +264,7 @@ class NativeEmitter {
}
}
}
- walk(cls);
+ walk(classElement);
String constantPart = "'${Strings.join(subtags, '|')}'";
if (constantPart != "''") expressions.add(constantPart);
String expression;
@@ -276,8 +276,8 @@ class NativeEmitter {
return expression;
}
- for (final ClassElement cls in dispatchClasses) {
- tagDefns[cls] = makeExpression(cls);
+ for (final ClassElement classElement in dispatchClasses) {
+ tagDefns[classElement] = makeExpression(classElement);
}
// Write out a thunk that builds the metadata.
« no previous file with comments | « no previous file | lib/compiler/implementation/native_handler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698