Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Unified Diff: lib/compiler/implementation/compiler.dart

Issue 10091037: Clean up handling of types. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Remove debug code. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/compiler.dart
diff --git a/lib/compiler/implementation/compiler.dart b/lib/compiler/implementation/compiler.dart
index 6602ce259171b2002ae467b267cd1c3aa224af62..dde5b0cfd9d5d1e76de943d01371d8b3e1f88be8 100644
--- a/lib/compiler/implementation/compiler.dart
+++ b/lib/compiler/implementation/compiler.dart
@@ -35,7 +35,7 @@ class Compiler implements DiagnosticListener {
Universe universe;
String assembledCode;
Namer namer;
- final Types types;
+ Types types;
final Tracer tracer;
@@ -96,8 +96,7 @@ class Compiler implements DiagnosticListener {
Stopwatch codegenProgress;
Compiler([this.tracer = const Tracer()])
- : types = new Types(),
- universe = new Universe(),
+ : universe = new Universe(),
worklist = new Queue<WorkItem>(),
codegenProgress = new Stopwatch.start() {
namer = new Namer(this);
@@ -213,17 +212,30 @@ class Compiler implements DiagnosticListener {
abstract LibraryElement scanBuiltinLibrary(String filename);
void initializeSpecialClasses() {
- objectClass = coreLibrary.find(const SourceString('Object'));
- boolClass = coreLibrary.find(const SourceString('bool'));
- numClass = coreLibrary.find(const SourceString('num'));
- intClass = coreLibrary.find(const SourceString('int'));
- doubleClass = coreLibrary.find(const SourceString('double'));
- stringClass = coreLibrary.find(const SourceString('String'));
- functionClass = coreLibrary.find(const SourceString('Function'));
- listClass = coreLibrary.find(const SourceString('List'));
- closureClass = jsHelperLibrary.find(const SourceString('Closure'));
- dynamicClass = types.dynamicType.element;
- nullClass = jsHelperLibrary.find(const SourceString('Null'));
+ bool coreLibValid = true;
+ ClassElement lookupSpecialClass(SourceString name) {
+ ClassElement result = coreLibrary.find(name);
+ if (result === null) {
+ log('core library class $name missing');
+ coreLibValid = false;
+ }
+ return result;
+ }
+ objectClass = lookupSpecialClass(const SourceString('Object'));
+ boolClass = lookupSpecialClass(const SourceString('bool'));
+ numClass = lookupSpecialClass(const SourceString('num'));
+ intClass = lookupSpecialClass(const SourceString('int'));
+ doubleClass = lookupSpecialClass(const SourceString('double'));
+ stringClass = lookupSpecialClass(const SourceString('String'));
+ functionClass = lookupSpecialClass(const SourceString('Function'));
+ listClass = lookupSpecialClass(const SourceString('List'));
+ closureClass = lookupSpecialClass(const SourceString('Closure'));
+ dynamicClass = lookupSpecialClass(const SourceString('Dynamic'));
+ nullClass = lookupSpecialClass(const SourceString('Null'));
+ types = new Types(dynamicClass);
+ if (!coreLibValid) {
+ cancel('core library does not contain required classes');
+ }
}
void scanBuiltinLibraries() {

Powered by Google App Engine
This is Rietveld 408576698