Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: lib/compiler/implementation/scanner/parser.dart

Issue 10091028: Fix type warnings and a few other warnings, and probably even an error. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/compiler/implementation/scanner/parser_bench.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/scanner/parser.dart
diff --git a/lib/compiler/implementation/scanner/parser.dart b/lib/compiler/implementation/scanner/parser.dart
index e2760019dafe340652dd45b369d19d68c6bd0355..3659db5752083be5d044b51c2f33c9d7c5d70322 100644
--- a/lib/compiler/implementation/scanner/parser.dart
+++ b/lib/compiler/implementation/scanner/parser.dart
@@ -937,7 +937,7 @@ class Parser {
mark = token;
if (optional('.', token)) {
Token period = token;
- token = parseSend(period.token);
+ token = parseSend(token);
listener.handleBinaryExpression(period);
}
token = parseArgumentOrIndexStar(token);
@@ -945,7 +945,7 @@ class Parser {
if (token.info.precedence === ASSIGNMENT_PRECEDENCE) {
Token assignment = token;
- token = parsePrecedenceExpression(token.token, CASCADE_PRECEDENCE + 1);
+ token = parsePrecedenceExpression(token, CASCADE_PRECEDENCE + 1);
listener.handleAssignmentExpression(assignment);
}
listener.endCascade();
@@ -1557,19 +1557,21 @@ class Parser {
// Then one or more case expressions, the last of which may be
// 'default' instead.
int expressionCount = 0;
- String value = token.stringValue;
- do {
- if (value === 'default') {
- defaultKeyword = token;
- token = expect(':', token.next);
- break;
- }
- token = expect('case', token);
- token = parseExpression(token);
- token = expect(':', token);
- expressionCount++;
- value = token.stringValue;
- } while (value === 'case' || value === 'default');
+ {
+ String value = token.stringValue;
+ do {
+ if (value === 'default') {
+ defaultKeyword = token;
+ token = expect(':', token.next);
+ break;
+ }
+ token = expect('case', token);
+ token = parseExpression(token);
+ token = expect(':', token);
+ expressionCount++;
+ value = token.stringValue;
+ } while (value === 'case' || value === 'default');
+ }
// Finally zero or more statements.
int statementCount = 0;
while (token.kind !== EOF_TOKEN) {
« no previous file with comments | « no previous file | lib/compiler/implementation/scanner/parser_bench.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698