Issue 10091027: Process weak references between optimized JSFunctions on scavenges.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10091027: Process weak references between optimized JSFunctions on scavenges. (Closed)

Created:
8 years, 8 months ago by Vyacheslav Egorov (Chromium)

Modified:
8 years, 8 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Process weak references between optimized JSFunctions on scavenges. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=11347

Patch Set 1 #

Patch Set 2 : fix incremental marking and slot recording #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -12 lines)			Patch
M	src/heap.cc	View	1	8 chunks	+64 lines, -3 lines	1 comment	Download
M	src/incremental-marking.cc	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/mark-compact.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/mark-compact.cc	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/objects-visiting.h	View		1 chunk	+14 lines, -0 lines	1 comment	Download
M	src/objects-visiting-inl.h	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

PTAL Fixed incremental marking and slot recording.

8 years, 8 months ago (2012-04-17 09:08:15 UTC) #2

Michael Starzinger

8 years, 8 months ago (2012-04-17 09:53:18 UTC) #3

LGTM (with nits).

http://codereview.chromium.org/10091027/diff/1004/src/heap.cc
File src/heap.cc (right):

http://codereview.chromium.org/10091027/diff/1004/src/heap.cc#newcode1390
src/heap.cc:1390: // Note that write barrier has not effect if we are already
the middle of
Missing "in" and s/not/no/

http://codereview.chromium.org/10091027/diff/1004/src/objects-visiting.h
File src/objects-visiting.h (right):

http://codereview.chromium.org/10091027/diff/1004/src/objects-visiting.h#newc...
src/objects-visiting.h:296: HeapObject::RawField(object,
JSFunction::kCodeEntryOffset));
Can we put a comment here saying that we don't visit the code entry slot because
it will always point to old-space or something like that?

Expand Messages | Collapse Messages