Issue 2089 Expose value wrapper's inner values

src/mirror-debugger.js

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 578 matching lines @@
 ObjectMirror.prototype.prototypeObject = function() {
   return MakeMirror(%DebugGetProperty(this.value_, 'prototype'));
 };
 
 
 ObjectMirror.prototype.protoObject = function() {
   return MakeMirror(%DebugGetPrototype(this.value_));
 };
 
 
+/**
+ * Return the primitive value if this is object of Boolean, Number or String type (but not Date).

[Yang, 2012/04/17 12:48:44]

Please keep the 80 character limit.

[Peter Rybin, 2012/04/18 12:36:09]

Sorry, too much programming in WebKit :)

+ * Otherwise return undefined. 
+ */
+ObjectMirror.prototype.primitiveValue = function() {
+  if (!IS_STRING_WRAPPER(this.value_) && !IS_NUMBER_WRAPPER(this.value_) && !IS_BOOLEAN_WRAPPER(this.value_)) {

[Yang, 2012/04/17 12:48:44]

Ditto.

[Peter Rybin, 2012/04/18 12:36:09]

Done.

+    return void 0;
+  }
+  var primitiveValue = %DebugGetPrimitiveValue(this.value_);
+  if (IS_UNDEFINED(primitiveValue)) {
+    return void 0;
+  }
+  return MakeMirror(primitiveValue);
+};
+
+
 ObjectMirror.prototype.hasNamedInterceptor = function() {
   // Get information on interceptors for this object.
   var x = %GetInterceptorInfo(this.value_);
   return (x & 2) != 0;
 };
 
 
 ObjectMirror.prototype.hasIndexedInterceptor = function() {
   // Get information on interceptors for this object.
   var x = %GetInterceptorInfo(this.value_);
@@ skipping 1617 matching lines @@
  *    "properties":[<properties>]}
  */
 JSONProtocolSerializer.prototype.serializeObject_ = function(mirror, content,
                                                              details) {
   // Add general object properties.
   content.className = mirror.className();
   content.constructorFunction =
       this.serializeReference(mirror.constructorFunction());
   content.protoObject = this.serializeReference(mirror.protoObject());
   content.prototypeObject = this.serializeReference(mirror.prototypeObject());
+  
+  var primitiveValue = mirror.primitiveValue();
+  if (!IS_UNDEFINED(primitiveValue)) {
+    content.primitiveValue = this.serializeReference(primitiveValue);
+  }
 
   // Add flags to indicate whether there are interceptors.
   if (mirror.hasNamedInterceptor()) {
     content.namedInterceptor = true;
   }
   if (mirror.hasIndexedInterceptor()) {
     content.indexedInterceptor = true;
   }
 
   // Add function specific properties.
@@ skipping 182 matching lines @@
   }
   if (!NUMBER_IS_FINITE(value)) {
     if (value > 0) {
       return 'Infinity';
     } else {
       return '-Infinity';
     }
   }
   return value;
 }