Issue 2089 Expose value wrapper's inner values

Issue 2089 Expose value wrapper's inner values

Committed: https://code.google.com/p/v8/source/detail?r=11371

[Yang, 2012-04-17 12:48:35]

On 2012/04/17 01:07:12, Peter Rybin wrote:

Please make sure that this is indeed necessary. See my comment on
http://code.google.com/p/v8/issues/detail?id=2089

[Yang, 2012-04-17 12:48:44]

https://chromiumcodereview.appspot.com/10091022/diff/1/src/mirror-debugger.js
File src/mirror-debugger.js (right):

https://chromiumcodereview.appspot.com/10091022/diff/1/src/mirror-debugger.js...
src/mirror-debugger.js:600: * Return the primitive value if this is object of
Boolean, Number or String type (but not Date).
Please keep the 80 character limit.

https://chromiumcodereview.appspot.com/10091022/diff/1/src/mirror-debugger.js...
src/mirror-debugger.js:604: if (!IS_STRING_WRAPPER(this.value_) &&
!IS_NUMBER_WRAPPER(this.value_) && !IS_BOOLEAN_WRAPPER(this.value_)) {
Ditto.

https://chromiumcodereview.appspot.com/10091022/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://chromiumcodereview.appspot.com/10091022/diff/1/src/runtime.cc#newcode...
src/runtime.cc:12287: }
This seems to do the same as %_ValueOf (see FullCodeGenerator::EmitValueOf).

[Peter Rybin, 2012-04-18 12:36:09]

https://chromiumcodereview.appspot.com/10091022/diff/1/src/mirror-debugger.js
File src/mirror-debugger.js (right):

https://chromiumcodereview.appspot.com/10091022/diff/1/src/mirror-debugger.js...
src/mirror-debugger.js:600: * Return the primitive value if this is object of
Boolean, Number or String type (but not Date).
On 2012/04/17 12:48:44, Yang wrote:
> Please keep the 80 character limit.

Sorry, too much programming in WebKit :)

https://chromiumcodereview.appspot.com/10091022/diff/1/src/mirror-debugger.js...
src/mirror-debugger.js:604: if (!IS_STRING_WRAPPER(this.value_) &&
!IS_NUMBER_WRAPPER(this.value_) && !IS_BOOLEAN_WRAPPER(this.value_)) {
On 2012/04/17 12:48:44, Yang wrote:
> Ditto.

Done.

https://chromiumcodereview.appspot.com/10091022/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://chromiumcodereview.appspot.com/10091022/diff/1/src/runtime.cc#newcode...
src/runtime.cc:12287: }
On 2012/04/17 12:48:44, Yang wrote:
> This seems to do the same as %_ValueOf (see FullCodeGenerator::EmitValueOf).

Done.

[Yang, 2012-04-18 13:29:59]

On 2012/04/18 12:36:09, Peter Rybin wrote:
> https://chromiumcodereview.appspot.com/10091022/diff/1/src/mirror-debugger.js
> File src/mirror-debugger.js (right):
> 
>
https://chromiumcodereview.appspot.com/10091022/diff/1/src/mirror-debugger.js...
> src/mirror-debugger.js:600: * Return the primitive value if this is object of
> Boolean, Number or String type (but not Date).
> On 2012/04/17 12:48:44, Yang wrote:
> > Please keep the 80 character limit.
> 
> Sorry, too much programming in WebKit :)
> 
>
https://chromiumcodereview.appspot.com/10091022/diff/1/src/mirror-debugger.js...
> src/mirror-debugger.js:604: if (!IS_STRING_WRAPPER(this.value_) &&
> !IS_NUMBER_WRAPPER(this.value_) && !IS_BOOLEAN_WRAPPER(this.value_)) {
> On 2012/04/17 12:48:44, Yang wrote:
> > Ditto.
> 
> Done.
> 
> https://chromiumcodereview.appspot.com/10091022/diff/1/src/runtime.cc
> File src/runtime.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10091022/diff/1/src/runtime.cc#newcode...
> src/runtime.cc:12287: }
> On 2012/04/17 12:48:44, Yang wrote:
> > This seems to do the same as %_ValueOf (see FullCodeGenerator::EmitValueOf).
> 
> Done.

LGTM.

[Michael Starzinger, 2012-04-18 19:06:14]

This CL is still against trunk (see "Base URL" on the left side). Better start a
new CL instead of reusing one that has already landed.

[Peter Rybin, 2012-04-20 16:21:10]

On 2012/04/18 19:06:14, Michael Starzinger wrote:
> This CL is still against trunk (see "Base URL" on the left side). Better start
a
> new CL instead of reusing one that has already landed.

Thank you for noting this. Yes, I was about to start committing it. Just wanted
to keep formal LGTM.