Issue 10091006: TabContents -> WebContentsImpl, part 15.

Issue 10091006: TabContents -> WebContentsImpl, part 15. (Closed)

Created:
8 years, 8 months ago by Avi (use Gerrit)

Modified:
8 years, 8 months ago

Reviewers:
jam

CC:
chromium-reviews, jam, mihaip+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

TabContents -> WebContentsImpl, part 15. Switch VIEW_TYPE_TAB_CONTENTS to VIEW_TYPE_WEB_CONTENTS. Also removed all references in comments to TAB_CONTENTS_WEB. TAB_CONTENTS_WEB was a value of the enum TabContentsType, which was removed in r13730. BUG=105875 TEST=no change Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132567

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -27 lines)			Patch
M	chrome/browser/bookmarks/bookmark_manager_extension_api.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/browser_about_handler.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/api/web_navigation/web_navigation_api.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/geolocation/chrome_geolocation_permission_context.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/extensions/extension_custom_bindings.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/render_view_host_impl.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	content/browser/speech/speech_recognition_manager_impl.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/web_contents/navigation_entry_impl.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/browser/interstitial_page.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/browser/navigation_entry.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	content/public/browser/notification_types.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/public/browser/web_contents.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/public/browser/web_contents_observer.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/public/common/view_type.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10091006/1

8 years, 8 months ago (2012-04-17 13:18:23 UTC) #3

commit-bot: I haz the power

8 years, 8 months ago (2012-04-17 13:18:31 UTC) #4

Presubmit check for 10091006-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/bookmarks

Presubmit checks took 1.6s to calculate.

Expand Messages | Collapse Messages