Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: Source/WebCore/rendering/RenderBox.cpp

Issue 10090001: Merge 112582 - REGRESSION (r110065-r110080): Content drawing outside overflow: hidden at ynet.co.il (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1084/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/platform/wk2/Skipped ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/rendering/RenderBox.cpp
===================================================================
--- Source/WebCore/rendering/RenderBox.cpp (revision 114144)
+++ Source/WebCore/rendering/RenderBox.cpp (working copy)
@@ -3722,6 +3722,12 @@
if (clientBox.contains(rect) || rect.isEmpty())
return;
+ // Lazily allocate our layer as we will need it to hold our scroll information
+ // and for the clipping logic to work properly. Note that we *do* need a layer
+ // if we have some left overflow on an horizontal writing mode with ltr direction.
+ if (hasOverflowClip())
+ ensureLayer();
+
// For overflow clip objects, we don't want to propagate overflow into unreachable areas.
LayoutRect overflowRect(rect);
if (hasOverflowClip() || isRenderView()) {
@@ -3756,10 +3762,6 @@
if (!m_overflow)
m_overflow = adoptPtr(new RenderOverflow(clientBox, borderBoxRect()));
- // Lazily allocate our layer as we will need it to hold our scroll information.
- if (hasOverflowClip())
- ensureLayer();
-
m_overflow->addLayoutOverflow(overflowRect);
}
« no previous file with comments | « LayoutTests/platform/wk2/Skipped ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698