Fixing issues with alignment, undefined behaviour and endianness in the FieldTrial::HashName functi…

Fixing issues with alignment, undefined behaviour and endianness in the FieldTrial::HashName function. I also added new functions to base that convert from host order to little endian.

BUG=123230
FieldTrialTest.HashName
TEST=FieldTrialTest.HashName


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132404

[MAD, 2012-04-13 16:16:12]

LGTM

Thanks!

BYE
MAD

[jar (doing other things), 2012-04-13 19:50:00]

lgtm

[Ilya Sherman, 2012-04-13 20:19:20]

https://chromiumcodereview.appspot.com/10088001/diff/1/base/sys_byteorder.h
File base/sys_byteorder.h (right):

https://chromiumcodereview.appspot.com/10088001/diff/1/base/sys_byteorder.h#n...
base/sys_byteorder.h:93: #endif
Hmm, why are you adding these functions rather than just using HostToNet32()? 
Is it important that the bytes be in little-endian order rather than in
big-endian order?

[jwd, 2012-04-13 20:33:43]

https://chromiumcodereview.appspot.com/10088001/diff/1/base/sys_byteorder.h
File base/sys_byteorder.h (right):

https://chromiumcodereview.appspot.com/10088001/diff/1/base/sys_byteorder.h#n...
base/sys_byteorder.h:93: #endif
We decided that we wanted the values in little-endian because of the existing
data and some arguments about the servers being mostly little-endian right now
anyway. 
On 2012/04/13 20:19:20, Ilya Sherman wrote:
> Hmm, why are you adding these functions rather than just using HostToNet32()? 
> Is it important that the bytes be in little-endian order rather than in
> big-endian order?

[Ilya Sherman, 2012-04-13 21:27:33]

lgtm

https://chromiumcodereview.appspot.com/10088001/diff/1/base/sys_byteorder.h
File base/sys_byteorder.h (right):

https://chromiumcodereview.appspot.com/10088001/diff/1/base/sys_byteorder.h#n...
base/sys_byteorder.h:93: #endif
On 2012/04/13 20:33:44, Jesse Doherty wrote:
> We decided that we wanted the values in little-endian because of the existing
> data and some arguments about the servers being mostly little-endian right now
> anyway.

Ok, fair enough.  Thanks :)

> On 2012/04/13 20:19:20, Ilya Sherman wrote:
> > Hmm, why are you adding these functions rather than just using
HostToNet32()? 
> > Is it important that the bytes be in little-endian order rather than in
> > big-endian order?
>

[commit-bot: I haz the power, 2012-04-13 21:27:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jwd@chromium.org/10088001/1

[commit-bot: I haz the power, 2012-04-13 22:05:04]

Try job failure for 10088001-1 (retry) on linux_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-04-16 13:58:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jwd@chromium.org/10088001/1

[commit-bot: I haz the power, 2012-04-16 15:29:28]

Change committed as 132404