Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10086018: More DomStorage house cleaning (Closed)

Created:
8 years, 8 months ago by michaeln
Modified:
8 years, 8 months ago
Reviewers:
joth, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Ben Murdoch, joth, jsbell
Visibility:
Public.

Description

More DomStorage house cleaning, many files but all mechanical changes. - delete old in_process_webkit sources (hooray) - rename the new sources to no longer have the _new suffix - fix up the includes - remove the ENABLE_NEW_DOM_STORAGE_BACKEND flag since old stuff is now gone Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132504

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2433 lines) Patch
M chrome/browser/browsing_data_local_storage_helper_browsertest.cc View 1 2 3 4 2 chunks +1 line, -9 lines 0 comments Download
M content/browser/browser_context.cc View 1 2 3 4 2 chunks +1 line, -12 lines 0 comments Download
A + content/browser/dom_storage/dom_storage_context_impl.h View 1 2 3 2 chunks +0 lines, -3 lines 0 comments Download
A + content/browser/dom_storage/dom_storage_context_impl.cc View 1 2 3 2 chunks +1 line, -5 lines 0 comments Download
M content/browser/dom_storage/dom_storage_context_impl_new.h View 1 2 3 4 1 chunk +0 lines, -75 lines 0 comments Download
M content/browser/dom_storage/dom_storage_context_impl_new.cc View 1 2 3 4 1 chunk +0 lines, -186 lines 0 comments Download
A + content/browser/dom_storage/dom_storage_message_filter.h View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
A + content/browser/dom_storage/dom_storage_message_filter.cc View 1 2 3 2 chunks +2 lines, -6 lines 0 comments Download
M content/browser/dom_storage/dom_storage_message_filter_new.h View 1 2 3 4 1 chunk +0 lines, -99 lines 0 comments Download
M content/browser/dom_storage/dom_storage_message_filter_new.cc View 1 2 3 4 1 chunk +0 lines, -208 lines 0 comments Download
A + content/browser/dom_storage/session_storage_namespace_impl.h View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
A + content/browser/dom_storage/session_storage_namespace_impl.cc View 1 2 3 2 chunks +2 lines, -6 lines 0 comments Download
M content/browser/dom_storage/session_storage_namespace_impl_new.h View 1 2 3 4 1 chunk +0 lines, -40 lines 0 comments Download
M content/browser/dom_storage/session_storage_namespace_impl_new.cc View 1 2 3 4 1 chunk +0 lines, -35 lines 0 comments Download
M content/browser/in_process_webkit/browser_webkitplatformsupport_impl.h View 1 2 3 4 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/in_process_webkit/browser_webkitplatformsupport_impl.cc View 1 2 3 4 2 chunks +0 lines, -27 lines 0 comments Download
D content/browser/in_process_webkit/dom_storage_area.h View 1 2 3 4 1 chunk +0 lines, -87 lines 0 comments Download
D content/browser/in_process_webkit/dom_storage_area.cc View 1 2 3 4 1 chunk +0 lines, -87 lines 0 comments Download
D content/browser/in_process_webkit/dom_storage_context_impl.h View 1 2 3 4 1 chunk +0 lines, -179 lines 0 comments Download
D content/browser/in_process_webkit/dom_storage_context_impl.cc View 1 2 3 4 1 chunk +0 lines, -384 lines 0 comments Download
D content/browser/in_process_webkit/dom_storage_message_filter.h View 1 2 3 4 1 chunk +0 lines, -99 lines 0 comments Download
D content/browser/in_process_webkit/dom_storage_message_filter.cc View 1 2 3 4 1 chunk +0 lines, -231 lines 0 comments Download
D content/browser/in_process_webkit/dom_storage_namespace.h View 1 2 3 4 1 chunk +0 lines, -91 lines 0 comments Download
D content/browser/in_process_webkit/dom_storage_namespace.cc View 1 2 3 4 1 chunk +0 lines, -117 lines 0 comments Download
D content/browser/in_process_webkit/dom_storage_unittest.cc View 1 2 3 4 1 chunk +0 lines, -182 lines 0 comments Download
D content/browser/in_process_webkit/session_storage_namespace_impl.h View 1 2 3 4 1 chunk +0 lines, -49 lines 0 comments Download
D content/browser/in_process_webkit/session_storage_namespace_impl.cc View 1 2 3 4 1 chunk +0 lines, -50 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 2 3 4 3 chunks +1 line, -7 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/web_contents/navigation_controller_impl.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
D content/common/dom_storage_common.h View 1 2 3 4 1 chunk +0 lines, -25 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 3 chunks +6 lines, -16 lines 0 comments Download
M content/content_common.gypi View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 1 chunk +0 lines, -8 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.h View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 2 3 4 1 chunk +0 lines, -21 lines 0 comments Download
M content/renderer/renderer_webstoragenamespace_impl.h View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/renderer_webstoragenamespace_impl.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M webkit/dom_storage/dom_storage_types.h View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
M webkit/support/test_webkit_platform_support.h View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/support/test_webkit_platform_support.cc View 1 2 3 4 1 chunk +0 lines, -16 lines 0 comments Download
M webkit/support/webkit_support.cc View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/test_shell_webkit_init.h View 1 2 3 4 1 chunk +0 lines, -6 lines 0 comments Download
M webkit/tools/test_shell/test_shell_webkit_init.cc View 1 2 3 4 1 chunk +0 lines, -19 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 1 2 3 4 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
michaeln
finally get to delete scads of stuff, very cathartic :)
8 years, 8 months ago (2012-04-14 00:07:26 UTC) #1
michaeln
similar cathartic house cleaning has already happened upstream http://trac.webkit.org/changeset/114160
8 years, 8 months ago (2012-04-14 00:11:19 UTC) #2
jam
lgtm
8 years, 8 months ago (2012-04-15 22:18:30 UTC) #3
joth
8 years, 8 months ago (2012-04-17 11:47:41 UTC) #4 
LGTM

Much cathartic redness. Thanks.

Powered by Google App Engine
This is Rietveld 408576698