Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: src/api.cc

Issue 10086006: External references should not affect dominance relation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressing comments. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/profile-generator.h » ('j') | src/profile-generator.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5980 matching lines...) Expand 10 before | Expand all | Expand 10 after
5991 edge->index()))); 5991 edge->index())));
5992 default: UNREACHABLE(); 5992 default: UNREACHABLE();
5993 } 5993 }
5994 return v8::Undefined(); 5994 return v8::Undefined();
5995 } 5995 }
5996 5996
5997 5997
5998 const HeapGraphNode* HeapGraphEdge::GetFromNode() const { 5998 const HeapGraphNode* HeapGraphEdge::GetFromNode() const {
5999 i::Isolate* isolate = i::Isolate::Current(); 5999 i::Isolate* isolate = i::Isolate::Current();
6000 IsDeadCheck(isolate, "v8::HeapGraphEdge::GetFromNode"); 6000 IsDeadCheck(isolate, "v8::HeapGraphEdge::GetFromNode");
6001 const i::HeapEntry* from = ToInternal(this)->From(); 6001 const i::HeapEntry* from = ToInternal(this)->from();
6002 return reinterpret_cast<const HeapGraphNode*>(from); 6002 return reinterpret_cast<const HeapGraphNode*>(from);
6003 } 6003 }
6004 6004
6005 6005
6006 const HeapGraphNode* HeapGraphEdge::GetToNode() const { 6006 const HeapGraphNode* HeapGraphEdge::GetToNode() const {
6007 i::Isolate* isolate = i::Isolate::Current(); 6007 i::Isolate* isolate = i::Isolate::Current();
6008 IsDeadCheck(isolate, "v8::HeapGraphEdge::GetToNode"); 6008 IsDeadCheck(isolate, "v8::HeapGraphEdge::GetToNode");
6009 const i::HeapEntry* to = ToInternal(this)->to(); 6009 const i::HeapEntry* to = ToInternal(this)->to();
6010 return reinterpret_cast<const HeapGraphNode*>(to); 6010 return reinterpret_cast<const HeapGraphNode*>(to);
6011 } 6011 }
(...skipping 388 matching lines...) Expand 10 before | Expand all | Expand 10 after
6400 6400
6401 6401
6402 char* HandleScopeImplementer::Iterate(ObjectVisitor* v, char* storage) { 6402 char* HandleScopeImplementer::Iterate(ObjectVisitor* v, char* storage) {
6403 HandleScopeImplementer* scope_implementer = 6403 HandleScopeImplementer* scope_implementer =
6404 reinterpret_cast<HandleScopeImplementer*>(storage); 6404 reinterpret_cast<HandleScopeImplementer*>(storage);
6405 scope_implementer->IterateThis(v); 6405 scope_implementer->IterateThis(v);
6406 return storage + ArchiveSpacePerThread(); 6406 return storage + ArchiveSpacePerThread();
6407 } 6407 }
6408 6408
6409 } } // namespace v8::internal 6409 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/profile-generator.h » ('j') | src/profile-generator.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698