Issue 10086005: ash: Show better focus rects for the tray.

Issue 10086005: ash: Show better focus rects for the tray. (Closed)

Created:
8 years, 8 months ago by sadrul

Modified:
8 years, 8 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ash: Show better focus rects for the tray. BUG=122933 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132261

Patch Set 2 : . #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -3 lines)			Patch
M	ash/system/audio/tray_volume.cc	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	ash/system/brightness/tray_brightness.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/system/power/tray_power.cc	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	ash/system/tray/tray_constants.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ash/system/tray/tray_constants.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ash/system/tray/tray_views.h	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	ash/system/tray/tray_views.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	ash/system/user/tray_user.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	ui/views/controls/slider.h	View	1	4 chunks	+6 lines, -0 lines	2 comments	Download
M	ui/views/controls/slider.cc	View	1	2 chunks	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

http://codereview.chromium.org/10086005/diff/1/ash/system/tray/tray_views.cc File ash/system/tray/tray_views.cc (right): http://codereview.chromium.org/10086005/diff/1/ash/system/tray/tray_views.cc#newcode201 ash/system/tray/tray_views.cc:201: if (HasFocus() && (focusable() || IsAccessibilityFocusable())) { Can you ...

8 years, 8 months ago (2012-04-13 15:26:29 UTC) #2

sadrul

8 years, 8 months ago (2012-04-13 15:48:36 UTC) #3

Ben Goodger (Google)

lgtm http://codereview.chromium.org/10086005/diff/4001/ui/views/controls/slider.h File ui/views/controls/slider.h (right): http://codereview.chromium.org/10086005/diff/4001/ui/views/controls/slider.h#newcode63 ui/views/controls/slider.h:63: void set_focus_color(SkColor color) { focus_color_ = color; } ...

8 years, 8 months ago (2012-04-13 20:13:42 UTC) #4

sadrul

8 years, 8 months ago (2012-04-13 20:42:46 UTC) #5

http://codereview.chromium.org/10086005/diff/4001/ui/views/controls/slider.h
File ui/views/controls/slider.h (right):

http://codereview.chromium.org/10086005/diff/4001/ui/views/controls/slider.h#...
ui/views/controls/slider.h:63: void set_focus_color(SkColor color) {
focus_color_ = color; }
On 2012/04/13 20:13:42, Ben Goodger (Google) wrote:
> set_focus_border_color

Done.

Expand Messages | Collapse Messages