Issue 10084030: views: Fix some DCHECKs to use (expected, actual) order.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10084030: views: Fix some DCHECKs to use (expected, actual) order. (Closed)

Created:
8 years, 8 months ago by tfarina

Modified:
8 years, 8 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, Aaron Boodman, yoshiki+watch_chromium.org, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

views: Fix some DCHECKs to use (expected, actual) order. R=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132439

Patch Set 1 #

Total comments: 1

Patch Set 2 : peter review -> revert one case #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -6 lines)			Patch
M	chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/infobars/extension_infobar.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/task_manager_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

8 years, 8 months ago (2012-04-16 18:16:25 UTC) #2

LGTM with one revert

http://codereview.chromium.org/10084030/diff/1/chrome/browser/ui/views/toolba...
File chrome/browser/ui/views/toolbar_view.cc (right):

http://codereview.chromium.org/10084030/diff/1/chrome/browser/ui/views/toolba...
chrome/browser/ui/views/toolbar_view.cc:356: DCHECK_EQ(source->id(),
VIEW_ID_APP_MENU);
The old code here was correct.

Expand Messages | Collapse Messages