Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2895)

Unified Diff: chrome/browser/ui/views/update_recommended_message_box.h

Issue 10084023: views: Create update recommended dialog inside the Show() function. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: peter review Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/update_recommended_message_box.h
diff --git a/chrome/browser/ui/views/update_recommended_message_box.h b/chrome/browser/ui/views/update_recommended_message_box.h
index 79a6229aab56c9e22e78fae4f7f6be19518a1033..41e0b1316651052d1f1cbf5035e68dad5ce97531 100644
--- a/chrome/browser/ui/views/update_recommended_message_box.h
+++ b/chrome/browser/ui/views/update_recommended_message_box.h
@@ -18,14 +18,14 @@ class MessageBoxView;
// the latest version to be put to use.
class UpdateRecommendedMessageBox : public views::DialogDelegate {
public:
- // This box is modal to |parent_window|.
- static void ShowMessageBox(gfx::NativeWindow parent_window);
+ static void Show(gfx::NativeWindow parent_window);
- // Overridden from views::DialogDelegate:
- virtual bool Accept() OVERRIDE;
+ private:
+ UpdateRecommendedMessageBox();
+ virtual ~UpdateRecommendedMessageBox();
- protected:
// Overridden from views::DialogDelegate:
+ virtual bool Accept() OVERRIDE;
virtual string16 GetDialogButtonLabel(ui::DialogButton button) const OVERRIDE;
// Overridden from views::WidgetDelegate:
@@ -37,10 +37,6 @@ class UpdateRecommendedMessageBox : public views::DialogDelegate {
virtual views::Widget* GetWidget() OVERRIDE;
virtual const views::Widget* GetWidget() const OVERRIDE;
- private:
- explicit UpdateRecommendedMessageBox(gfx::NativeWindow parent_window);
- virtual ~UpdateRecommendedMessageBox();
-
views::MessageBoxView* message_box_view_;
DISALLOW_COPY_AND_ASSIGN(UpdateRecommendedMessageBox);
« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.cc ('k') | chrome/browser/ui/views/update_recommended_message_box.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698