Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 10084003: Valgrind cleanliness, part 6: Introduce OS::TearDown, cleaning up 2 mutexes. (Closed)

Created:
8 years, 8 months ago by Sven Panne
Modified:
8 years, 8 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Valgrind cleanliness, part 6: Introduce OS::TearDown, cleaning up 2 mutexes. Committed: https://code.google.com/p/v8/source/detail?r=11320

Patch Set 1 #

Patch Set 2 : Fixed typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -36 lines) Patch
M src/platform.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/platform-cygwin.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M src/platform-freebsd.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M src/platform-linux.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M src/platform-macos.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M src/platform-nullos.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/platform-openbsd.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M src/platform-solaris.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M src/platform-win32.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M src/v8.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
8 years, 8 months ago (2012-04-13 11:51:21 UTC) #1
Erik Corry
8 years, 8 months ago (2012-04-13 12:18:37 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698