frog/tests/leg/src/TypeInferenceTest.dart - Issue 10084002: Add the first phi's input as possible generate-at-use-site.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: frog/tests/leg/src/TypeInferenceTest.dart

Issue 10084002: Add the first phi's input as possible generate-at-use-site. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address review comments. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: frog/tests/leg/src/TypeInferenceTest.dart

diff --git a/frog/tests/leg/src/TypeInferenceTest.dart b/frog/tests/leg/src/TypeInferenceTest.dart

index 775b2164741df14c56fcd0c4ffff85544afa7180..863b76d7f954079e1617fcae790cacc47e374c07 100644

--- a/frog/tests/leg/src/TypeInferenceTest.dart

+++ b/frog/tests/leg/src/TypeInferenceTest.dart

@@ -54,8 +54,7 @@ main() {

Expect.isFalse(regexp.hasMatch(generated));

regexp = new RegExp("sum = \$?$anyIdentifier \\+ $anyIdentifier\$?");

- // TODO(ngeoffray): Do live range analysis to make this test pass.

- Expect.isFalse(regexp.hasMatch(generated));

+ Expect.isTrue(regexp.hasMatch(generated));

regexp = const RegExp("typeof param0 !== 'number'");

Expect.isTrue(regexp.hasMatch(generated));

« no previous file with comments | « frog/tests/leg/src/SsaPhiCodegenTest.dart ('k') | lib/compiler/implementation/ssa/codegen_helpers.dart » ('j') | no next file with comments »