Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: frog/tests/leg/src/SsaPhiCodegenTest.dart

Issue 10084002: Add the first phi's input as possible generate-at-use-site. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address review comments. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | frog/tests/leg/src/TypeInferenceTest.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/tests/leg/src/SsaPhiCodegenTest.dart
diff --git a/frog/tests/leg/src/SsaPhiCodegenTest.dart b/frog/tests/leg/src/SsaPhiCodegenTest.dart
index dad164904b8c343f620bec4fa624ad6582914143..6b2b5d633f07ef75686957187247f443ebcb3760 100644
--- a/frog/tests/leg/src/SsaPhiCodegenTest.dart
+++ b/frog/tests/leg/src/SsaPhiCodegenTest.dart
@@ -65,12 +65,12 @@ main() {
regexp = const RegExp(@"print\(a\)");
Expect.isTrue(regexp.hasMatch(generated));
- // TODO(ngeoffray): Add live range analysis to the codegen
- // to make this test pass.
generated = compile(TEST_TWO, 'main');
regexp = new RegExp("t = \\(?$anyIdentifier +");
- Expect.isFalse(regexp.hasMatch(generated));
+ Expect.isTrue(regexp.hasMatch(generated));
+ // TODO(ngeoffray): Add live range analysis to the codegen
+ // to make this test pass.
regexp = new RegExp("i = \\(?$anyIdentifier +");
Expect.isFalse(regexp.hasMatch(generated));
« no previous file with comments | « no previous file | frog/tests/leg/src/TypeInferenceTest.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698