GpuMemoryManager suggests values for renderer Contents Texture Managers' preferred memory limit.

content/common/gpu/gpu_memory_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/gpu_command_buffer_stub.h"
 #include "content/common/gpu/gpu_memory_allocation.h"
 #include "content/common/gpu/gpu_memory_manager.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 180 matching lines @@
   EXPECT_EQ(stub2.allocation_.suggest_have_backbuffer, false);
 
   // Test stubs without surface, with share group of 1 stub.
   FakeCommandBufferStubWithoutSurface stub3, stub4;
   stub3.share_group_.push_back(&stub1);
   stub4.share_group_.push_back(&stub2);
   client_.stubs_.push_back(&stub3);
   client_.stubs_.push_back(&stub4);
 
   Manage();
-  EXPECT_EQ(stub1.allocation_, stub3.allocation_);
-  EXPECT_EQ(stub2.allocation_, stub4.allocation_);
+  EXPECT_GT(stub1.allocation_.gpu_resource_size_in_bytes, 1ul);

[mmocny, 2012/04/20 18:47:30]

I am already working on making it clearer why and when we expect allocation
values to be GT/EQ 0 etc.  Sorry to have hard coded values for now I just wanted
to make sure Manage function is functional after refactoring.

+  EXPECT_EQ(stub2.allocation_.gpu_resource_size_in_bytes, 0ul);
+  EXPECT_GT(stub3.allocation_.gpu_resource_size_in_bytes, 1ul);
+  EXPECT_EQ(stub4.allocation_.gpu_resource_size_in_bytes, 1ul);
 
   // Test stub without surface, with share group of multiple stubs.
   FakeCommandBufferStubWithoutSurface stub5;
   stub5.share_group_.push_back(&stub1);
   stub5.share_group_.push_back(&stub2);
   client_.stubs_.push_back(&stub5);
 
   Manage();
-  EXPECT_EQ(stub1.allocation_, stub5.allocation_);
+  EXPECT_GT(stub5.allocation_.gpu_resource_size_in_bytes, 1ul);
 }
 
 // Test GpuMemoryManager::Manage functionality: changing visibility.
 // Expect memory allocation to set suggest_have_frontbuffer/backbuffer according
 // to visibility and last used time for stubs with surface.
 // Expect memory allocation to be shared according to share groups for stubs
 // without a surface.
 TEST_F(GpuMemoryManagerTest, TestManageChangingVisibility) {
   FakeCommandBufferStub stub1(GenerateUniqueSurfaceId(), true, older_),
                         stub2(GenerateUniqueSurfaceId(), false, older_);
   client_.stubs_.push_back(&stub1);
   client_.stubs_.push_back(&stub2);
 
   FakeCommandBufferStubWithoutSurface stub3, stub4;
   stub3.share_group_.push_back(&stub1);
   stub4.share_group_.push_back(&stub2);
   client_.stubs_.push_back(&stub3);
   client_.stubs_.push_back(&stub4);
 
   FakeCommandBufferStubWithoutSurface stub5;
   stub5.share_group_.push_back(&stub1);
   stub5.share_group_.push_back(&stub2);
   client_.stubs_.push_back(&stub5);
 
   Manage();
   EXPECT_EQ(stub1.allocation_.suggest_have_frontbuffer, true);
   EXPECT_EQ(stub1.allocation_.suggest_have_backbuffer, true);
   EXPECT_EQ(stub2.allocation_.suggest_have_frontbuffer, true);
   EXPECT_EQ(stub2.allocation_.suggest_have_backbuffer, false);
-  EXPECT_EQ(stub1.allocation_, stub3.allocation_);
-  EXPECT_EQ(stub2.allocation_, stub4.allocation_);
-  EXPECT_EQ(stub1.allocation_, stub5.allocation_);
+  EXPECT_GT(stub1.allocation_.gpu_resource_size_in_bytes, 1ul);
+  EXPECT_EQ(stub2.allocation_.gpu_resource_size_in_bytes, 0ul);
+  EXPECT_GT(stub3.allocation_.gpu_resource_size_in_bytes, 1ul);
+  EXPECT_EQ(stub4.allocation_.gpu_resource_size_in_bytes, 1ul);
+  EXPECT_GT(stub5.allocation_.gpu_resource_size_in_bytes, 1ul);
 
   stub1.surface_state_.visible = false;
   stub2.surface_state_.visible = true;
 
   Manage();
   EXPECT_EQ(stub1.allocation_.suggest_have_frontbuffer, true);
   EXPECT_EQ(stub1.allocation_.suggest_have_backbuffer, false);
   EXPECT_EQ(stub2.allocation_.suggest_have_frontbuffer, true);
   EXPECT_EQ(stub2.allocation_.suggest_have_backbuffer, true);
-  EXPECT_EQ(stub1.allocation_, stub3.allocation_);
-  EXPECT_EQ(stub2.allocation_, stub4.allocation_);
-  EXPECT_EQ(stub2.allocation_, stub5.allocation_);
+  EXPECT_EQ(stub1.allocation_.gpu_resource_size_in_bytes, 0ul);
+  EXPECT_GT(stub2.allocation_.gpu_resource_size_in_bytes, 1ul);
+  EXPECT_EQ(stub3.allocation_.gpu_resource_size_in_bytes, 1ul);
+  EXPECT_GT(stub4.allocation_.gpu_resource_size_in_bytes, 1ul);
+  EXPECT_GT(stub5.allocation_.gpu_resource_size_in_bytes, 1ul);
 }
 
 // Test GpuMemoryManager::Manage functionality: Test more than threshold number
 // of visible stubs.
 // Expect all allocations to continue to have frontbuffer.
 TEST_F(GpuMemoryManagerTest, TestManageManyVisibleStubs) {
   FakeCommandBufferStub stub1(GenerateUniqueSurfaceId(), true, older_),
                         stub2(GenerateUniqueSurfaceId(), true, older_),
                         stub3(GenerateUniqueSurfaceId(), true, older_),
                         stub4(GenerateUniqueSurfaceId(), true, older_);
@@ skipping 15 matching lines @@
 
   Manage();
   EXPECT_EQ(stub1.allocation_.suggest_have_frontbuffer, true);
   EXPECT_EQ(stub1.allocation_.suggest_have_backbuffer, true);
   EXPECT_EQ(stub2.allocation_.suggest_have_frontbuffer, true);
   EXPECT_EQ(stub2.allocation_.suggest_have_backbuffer, true);
   EXPECT_EQ(stub3.allocation_.suggest_have_frontbuffer, true);
   EXPECT_EQ(stub3.allocation_.suggest_have_backbuffer, true);
   EXPECT_EQ(stub4.allocation_.suggest_have_frontbuffer, true);
   EXPECT_EQ(stub4.allocation_.suggest_have_backbuffer, true);
-  EXPECT_EQ(stub5.allocation_, stub1.allocation_);
-  EXPECT_EQ(stub6.allocation_, stub2.allocation_);
-  EXPECT_EQ(stub7.allocation_, stub1.allocation_);
+  EXPECT_GT(stub5.allocation_.gpu_resource_size_in_bytes, 1ul);
+  EXPECT_GT(stub6.allocation_.gpu_resource_size_in_bytes, 1ul);
+  EXPECT_GT(stub7.allocation_.gpu_resource_size_in_bytes, 1ul);
 }
 
 // Test GpuMemoryManager::Manage functionality: Test more than threshold number
 // of not visible stubs.
 // Expect the stubs surpassing the threshold to not have a backbuffer.
 TEST_F(GpuMemoryManagerTest, TestManageManyNotVisibleStubs) {
   FakeCommandBufferStub stub1(GenerateUniqueSurfaceId(), false, newer_),
                         stub2(GenerateUniqueSurfaceId(), false, newer_),
                         stub3(GenerateUniqueSurfaceId(), false, newer_),
                         stub4(GenerateUniqueSurfaceId(), false, older_);
@@ skipping 15 matching lines @@
 
   Manage();
   EXPECT_EQ(stub1.allocation_.suggest_have_frontbuffer, true);
   EXPECT_EQ(stub1.allocation_.suggest_have_backbuffer, false);
   EXPECT_EQ(stub2.allocation_.suggest_have_frontbuffer, true);
   EXPECT_EQ(stub2.allocation_.suggest_have_backbuffer, false);
   EXPECT_EQ(stub3.allocation_.suggest_have_frontbuffer, true);
   EXPECT_EQ(stub3.allocation_.suggest_have_backbuffer, false);
   EXPECT_EQ(stub4.allocation_.suggest_have_frontbuffer, false);
   EXPECT_EQ(stub4.allocation_.suggest_have_backbuffer, false);
-  EXPECT_EQ(stub5.allocation_, stub1.allocation_);
-  EXPECT_EQ(stub6.allocation_, stub4.allocation_);
-  EXPECT_EQ(stub7.allocation_, stub1.allocation_);
+  EXPECT_EQ(stub5.allocation_.gpu_resource_size_in_bytes, 1ul);
+  EXPECT_EQ(stub6.allocation_.gpu_resource_size_in_bytes, 0ul);
+  EXPECT_EQ(stub7.allocation_.gpu_resource_size_in_bytes, 1ul);
 }
 
 // Test GpuMemoryManager::Manage functionality: Test changing the last used
 // time of stubs when doing so causes change in which stubs surpass threshold.
 // Expect frontbuffer to be dropped for the older stub.
 TEST_F(GpuMemoryManagerTest, TestManageChangingLastUsedTime) {
   FakeCommandBufferStub stub1(GenerateUniqueSurfaceId(), false, newer_),
                         stub2(GenerateUniqueSurfaceId(), false, newer_),
                         stub3(GenerateUniqueSurfaceId(), false, newer_),
                         stub4(GenerateUniqueSurfaceId(), false, older_);
@@ skipping 11 matching lines @@
   FakeCommandBufferStubWithoutSurface stub7;
   stub7.share_group_.push_back(&stub3);
   stub7.share_group_.push_back(&stub4);
   client_.stubs_.push_back(&stub7);
 
   Manage();
   EXPECT_EQ(stub3.allocation_.suggest_have_frontbuffer, true);
   EXPECT_EQ(stub3.allocation_.suggest_have_backbuffer, false);
   EXPECT_EQ(stub4.allocation_.suggest_have_frontbuffer, false);
   EXPECT_EQ(stub4.allocation_.suggest_have_backbuffer, false);
-  EXPECT_EQ(stub5.allocation_, stub3.allocation_);
-  EXPECT_EQ(stub6.allocation_, stub4.allocation_);
-  EXPECT_EQ(stub7.allocation_, stub3.allocation_);
+  EXPECT_EQ(stub5.allocation_.gpu_resource_size_in_bytes, 1ul);
+  EXPECT_EQ(stub6.allocation_.gpu_resource_size_in_bytes, 0ul);
+  EXPECT_EQ(stub7.allocation_.gpu_resource_size_in_bytes, 1ul);
 
   stub3.surface_state_.last_used_time = older_;
   stub4.surface_state_.last_used_time = newer_;
 
   Manage();
   EXPECT_EQ(stub3.allocation_.suggest_have_frontbuffer, false);
   EXPECT_EQ(stub3.allocation_.suggest_have_backbuffer, false);
   EXPECT_EQ(stub4.allocation_.suggest_have_frontbuffer, true);
   EXPECT_EQ(stub4.allocation_.suggest_have_backbuffer, false);
-  EXPECT_EQ(stub5.allocation_, stub3.allocation_);
-  EXPECT_EQ(stub6.allocation_, stub4.allocation_);
-  EXPECT_EQ(stub7.allocation_, stub4.allocation_);
+  EXPECT_EQ(stub5.allocation_.gpu_resource_size_in_bytes, 0ul);
+  EXPECT_EQ(stub6.allocation_.gpu_resource_size_in_bytes, 1ul);
+  EXPECT_EQ(stub7.allocation_.gpu_resource_size_in_bytes, 1ul);
 }
 
 // Test GpuMemoryManager::Manage functionality: Test changing importance of
 // enough stubs so that every stub in share group crosses threshold.
 // Expect memory allocation of the stubs without surface to share memory
 // allocation with the most visible stub in share group.
 TEST_F(GpuMemoryManagerTest, TestManageChangingImportanceShareGroup) {
   FakeCommandBufferStub stubA(GenerateUniqueSurfaceId(), true, newer_),
                         stubB(GenerateUniqueSurfaceId(), false, newer_),
                         stubC(GenerateUniqueSurfaceId(), false, newer_);
@@ skipping 11 matching lines @@
   stub4.share_group_.push_back(&stub1);
   stub4.share_group_.push_back(&stub2);
   client_.stubs_.push_back(&stub3);
   client_.stubs_.push_back(&stub4);
 
   Manage();
   EXPECT_EQ(stub1.allocation_.suggest_have_frontbuffer, true);
   EXPECT_EQ(stub1.allocation_.suggest_have_backbuffer, true);
   EXPECT_EQ(stub2.allocation_.suggest_have_frontbuffer, true);
   EXPECT_EQ(stub2.allocation_.suggest_have_backbuffer, true);
-  EXPECT_EQ(stub3.allocation_, stub1.allocation_);
-  EXPECT_EQ(stub3.allocation_, stub2.allocation_);
-  EXPECT_EQ(stub4.allocation_, stub1.allocation_);
-  EXPECT_EQ(stub4.allocation_, stub2.allocation_);
+  EXPECT_GT(stub1.allocation_.gpu_resource_size_in_bytes, 1ul);
+  EXPECT_GT(stub2.allocation_.gpu_resource_size_in_bytes, 1ul);
+  EXPECT_GT(stub3.allocation_.gpu_resource_size_in_bytes, 1ul);
+  EXPECT_GT(stub4.allocation_.gpu_resource_size_in_bytes, 1ul);
 
   stub1.surface_state_.visible = false;
 
   Manage();
   EXPECT_EQ(stub1.allocation_.suggest_have_frontbuffer, true);
   EXPECT_EQ(stub1.allocation_.suggest_have_backbuffer, false);
   EXPECT_EQ(stub2.allocation_.suggest_have_frontbuffer, true);
   EXPECT_EQ(stub2.allocation_.suggest_have_backbuffer, true);
-  EXPECT_NE(stub3.allocation_, stub1.allocation_);
-  EXPECT_EQ(stub3.allocation_, stub2.allocation_);
-  EXPECT_NE(stub4.allocation_, stub1.allocation_);
-  EXPECT_EQ(stub4.allocation_, stub2.allocation_);
+  EXPECT_EQ(stub1.allocation_.gpu_resource_size_in_bytes, 0ul);
+  EXPECT_GT(stub2.allocation_.gpu_resource_size_in_bytes, 1ul);
+  EXPECT_GT(stub3.allocation_.gpu_resource_size_in_bytes, 1ul);
+  EXPECT_GT(stub4.allocation_.gpu_resource_size_in_bytes, 1ul);
 
   stub2.surface_state_.visible = false;
 
   Manage();
   EXPECT_EQ(stub1.allocation_.suggest_have_frontbuffer, true);
   EXPECT_EQ(stub1.allocation_.suggest_have_backbuffer, false);
   EXPECT_EQ(stub2.allocation_.suggest_have_frontbuffer, true);
   EXPECT_EQ(stub2.allocation_.suggest_have_backbuffer, false);
-  EXPECT_EQ(stub3.allocation_, stub1.allocation_);
-  EXPECT_EQ(stub3.allocation_, stub2.allocation_);
-  EXPECT_EQ(stub4.allocation_, stub1.allocation_);
-  EXPECT_EQ(stub4.allocation_, stub2.allocation_);
+  EXPECT_EQ(stub1.allocation_.gpu_resource_size_in_bytes, 0ul);
+  EXPECT_EQ(stub2.allocation_.gpu_resource_size_in_bytes, 0ul);
+  EXPECT_EQ(stub3.allocation_.gpu_resource_size_in_bytes, 1ul);
+  EXPECT_EQ(stub4.allocation_.gpu_resource_size_in_bytes, 1ul);
 
   stub1.surface_state_.last_used_time = older_;
 
   Manage();
   EXPECT_EQ(stub1.allocation_.suggest_have_frontbuffer, false);
   EXPECT_EQ(stub1.allocation_.suggest_have_backbuffer, false);
   EXPECT_EQ(stub2.allocation_.suggest_have_frontbuffer, true);
   EXPECT_EQ(stub2.allocation_.suggest_have_backbuffer, false);
-  EXPECT_NE(stub3.allocation_, stub1.allocation_);
-  EXPECT_EQ(stub3.allocation_, stub2.allocation_);
-  EXPECT_NE(stub4.allocation_, stub1.allocation_);
-  EXPECT_EQ(stub4.allocation_, stub2.allocation_);
+  EXPECT_EQ(stub1.allocation_.gpu_resource_size_in_bytes, 0ul);
+  EXPECT_EQ(stub2.allocation_.gpu_resource_size_in_bytes, 0ul);
+  EXPECT_EQ(stub3.allocation_.gpu_resource_size_in_bytes, 1ul);
+  EXPECT_EQ(stub4.allocation_.gpu_resource_size_in_bytes, 1ul);
 
   stub2.surface_state_.last_used_time = older_;
 
   Manage();
   EXPECT_EQ(stub1.allocation_.suggest_have_frontbuffer, false);
   EXPECT_EQ(stub1.allocation_.suggest_have_backbuffer, false);
   EXPECT_EQ(stub2.allocation_.suggest_have_frontbuffer, false);
   EXPECT_EQ(stub2.allocation_.suggest_have_backbuffer, false);
-  EXPECT_EQ(stub3.allocation_, stub1.allocation_);
-  EXPECT_EQ(stub3.allocation_, stub2.allocation_);
-  EXPECT_EQ(stub4.allocation_, stub1.allocation_);
-  EXPECT_EQ(stub4.allocation_, stub2.allocation_);
+  EXPECT_EQ(stub1.allocation_.gpu_resource_size_in_bytes, 0ul);
+  EXPECT_EQ(stub2.allocation_.gpu_resource_size_in_bytes, 0ul);
+  EXPECT_EQ(stub3.allocation_.gpu_resource_size_in_bytes, 0ul);
+  EXPECT_EQ(stub4.allocation_.gpu_resource_size_in_bytes, 0ul);
 }
 
 // Test GpuMemoryAllocation comparison operators: Iterate over all possible
 // combinations of gpu_resource_size_in_bytes, suggest_have_backbuffer, and
 // suggest_have_frontbuffer, and make sure allocations with equal values test
 // equal and non equal values test not equal.
 TEST_F(GpuMemoryManagerTest, GpuMemoryAllocationCompareTests) {
   int gpu_resource_size_in_bytes_values[] = { 0, 1, 12345678 };
   bool suggest_have_backbuffer_values[] = { false, true };
   bool suggest_have_frontbuffer_values[] = { false, true };
 
   for(int* sz = &gpu_resource_size_in_bytes_values[0];
       sz != &gpu_resource_size_in_bytes_values[3]; ++sz) {
     for(bool* shbb = &suggest_have_backbuffer_values[0];
         shbb != &suggest_have_backbuffer_values[2]; ++shbb) {
       for(bool* shfb = &suggest_have_frontbuffer_values[0];
           shfb != &suggest_have_frontbuffer_values[2]; ++shfb) {
         GpuMemoryAllocation allocation(*sz, *shbb, *shfb);
         EXPECT_EQ(allocation, GpuMemoryAllocation(*sz, *shbb, *shfb));
         EXPECT_NE(allocation, GpuMemoryAllocation(*sz+1, *shbb, *shfb));
         EXPECT_NE(allocation, GpuMemoryAllocation(*sz, !*shbb, *shfb));
         EXPECT_NE(allocation, GpuMemoryAllocation(*sz, *shbb, !*shfb));
       }
     }
   }
 }