IndexedDB: Support get/getKey(keyRange)

content/common/indexed_db/proxy_webidbobjectstore_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_COMMON_INDEXED_DB_PROXY_WEBIDBOBJECTSTORE_IMPL_H_
 #define CONTENT_COMMON_INDEXED_DB_PROXY_WEBIDBOBJECTSTORE_IMPL_H_
 #pragma once
 
 #include "base/basictypes.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebIDBCallbacks.h"
@@ skipping 14 matching lines @@
 
   // WebKit::WebIDBObjectStore
   virtual WebKit::WebString name() const;
   virtual WebKit::WebString keyPath() const;
   virtual WebKit::WebDOMStringList indexNames() const;
 
   virtual void get(const WebKit::WebIDBKey& key,
                    WebKit::WebIDBCallbacks* callbacks,
                    const WebKit::WebIDBTransaction& transaction,
                    WebKit::WebExceptionCode& ec);
+  virtual void get(const WebKit::WebIDBKeyRange&,

[jsbell, 2012/04/18 19:23:44]

Parameters aren't named; I'm not finding guidance in the Chromium or Google
style guide. Other method declarations have them, so include them?

[alecflett, 2012/04/18 20:16:07]

Fixed to at least be consistent with the file

+                   WebKit::WebIDBCallbacks*,
+                   const WebKit::WebIDBTransaction&,
+                   WebKit::WebExceptionCode&);
   virtual void put(const WebKit::WebSerializedScriptValue& value,
                    const WebKit::WebIDBKey& key,
                    PutMode put_mode,
                    WebKit::WebIDBCallbacks* callbacks,
                    const WebKit::WebIDBTransaction& transaction,
                    WebKit::WebExceptionCode& ec);
   virtual void deleteFunction(const WebKit::WebIDBKey& key,
                               WebKit::WebIDBCallbacks* callbacks,
                               const WebKit::WebIDBTransaction& transaction,
                               WebKit::WebExceptionCode& ec);
@@ skipping 28 matching lines @@
   virtual void count(const WebKit::WebIDBKeyRange& idb_key_range,
                      WebKit::WebIDBCallbacks* callbacks,
                      const WebKit::WebIDBTransaction& transaction,
                      WebKit::WebExceptionCode& ec);
 
  private:
   int32 idb_object_store_id_;
 };
 
 #endif  // CONTENT_COMMON_INDEXED_DB_PROXY_WEBIDBOBJECTSTORE_IMPL_H_