Issue 10083044: Fixed type transitions for mod on ia32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10083044: Fixed type transitions for mod on ia32. (Closed)

Created:
8 years, 8 months ago by Sven Panne

Modified:
8 years, 8 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fixed type transitions for mod on ia32. Previously we got stuck in the int32 state, because this handled everything without a type transition. Note that other platforms do not have this bug. Committed: https://code.google.com/p/v8/source/detail?r=11381

Patch Set 1 #

Patch Set 2 : Keep in the int32 state if possible #

Total comments: 2

Patch Set 3 : Removed dead code #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -44 lines)			Patch
	M	src/ia32/code-stubs-ia32.cc	View	1 2	7 chunks	+49 lines, -44 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

lgtm http://codereview.chromium.org/10083044/diff/3/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): http://codereview.chromium.org/10083044/diff/3/src/ia32/code-stubs-ia32.cc#newcode1745 src/ia32/code-stubs-ia32.cc:1745: case Token::MOD: this seems redundant

8 years, 8 months ago (2012-04-19 07:12:30 UTC) #2

Sven Panne

8 years, 8 months ago (2012-04-19 07:17:36 UTC) #3

Nit addressed, landing...

http://codereview.chromium.org/10083044/diff/3/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):

http://codereview.chromium.org/10083044/diff/3/src/ia32/code-stubs-ia32.cc#ne...
src/ia32/code-stubs-ia32.cc:1745: case Token::MOD:
On 2012/04/19 07:12:30, Vyacheslav Egorov wrote:
> this seems redundant

Ooops, this is a remainder of my previous attempts to get this method into a
less embarrassing form... :-) Removed.

Expand Messages | Collapse Messages