Issue 10083017: Revert r132300 "Delete unused icons"

Issue 10083017: Revert r132300 "Delete unused icons" (Closed)

Created:
8 years, 8 months ago by oshima

Modified:
8 years, 8 months ago

Reviewers:
sail

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert r132300 "Delete unused icons" TBR=sail@chromium.org BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132301

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+-15 lines, --22 lines)			Patch
A	chrome/app/theme/about_conflicts.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/compact_wrench_button.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/compact_wrench_button_h.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/compact_wrench_tag_aero.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/compact_wrench_tag_opaque.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/flags_section.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/ntp_menu_mask.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/ntp_option.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/ntp_option_h.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/ntp_option_p.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/print_preview_favicon.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/profile_edit.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/profile_edit_hover.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/profile_edit_pressed.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/sidebar_tab_active.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/sidebar_tab_inactive.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/app/theme/theme_resources.grd	View	2 chunks	+7 lines, -0 lines	0 comments	Download
A	chrome/app/theme/theme_tab_background2.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/toolbar_divider.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/touch_newtab.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/touch_newtab_button_mask.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/touch_newtab_h.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/touch_newtab_p.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

oshima

8 years, 8 months ago (2012-04-14 02:17:51 UTC) #1

Here are logs from linux build

http://build.chromium.org/p/chromium/builders/Linux%20Builder%20%28dbg%29/bui...

make: *** No rule to make target `chrome/app/theme/flags_section.png', needed by
`out/Debug/obj/gen/chrome/grit/browser_resources.h'.
make: *** No rule to make target `chrome/app/theme/print_preview_favicon.png',
needed by `out/Debug/obj/gen/chrome/grit/browser_resources.h'.
  ACTION Generating resources from app/theme/theme_resources.grd
out/Debug/obj/gen/chrome/grit/theme_resources.h
  RULE gdata_proto_genproto_0
out/Debug/pyproto/chrome/browser/chromeos/gdata/gdata_pb2.py
make: Nothing to be done for `cacheinvalidation_unittests'.

mac/andriod were also failing.


-- android
make: *** No rule to make target `chrome/app/theme/flags_section.png', needed by
`out/Release/obj/gen/chrome/grit/browser_resources.h'.  Stop.
make: *** Waiting for unfinished jobs....

-- mac
http://build.chromium.org/p/chromium/builders/Mac%20Builder%20%28dbg%29/build...

Exception: Failed to open browser/resources/../../app/theme/flags_section.png
while trying to flatten browser/resources/flags.html. (No such file or
directory)

Expand Messages | Collapse Messages