Issue 10083011: Fixes for the EnumeratesPE base_unittest failures seen on Windows 8 X64. The values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10083011: Fixes for the EnumeratesPE base_unittest failures seen on Windows 8 X64. The values (Closed)

Created:
8 years, 8 months ago by ananta

Modified:
8 years, 8 months ago

Reviewers:
cpu_(ooo_6.6-7.5), jar (doing other things)

CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fixes for the EnumeratesPE base_unittest failures seen on Windows 8 X64. The values used by this test for sections and import dlls, needed to be changed. These values are different for X86 and X64. BUG=123096 R=cpu Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132278

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	base/win/pe_image_unittest.cc	View	1	1 chunk	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jar (doing other things)

8 years, 8 months ago (2012-04-13 21:43:45 UTC) #3

Providing a rubber stamp LGTM for CL that looks very reasonable... and that cpu
has already reviewed.

Expand Messages | Collapse Messages