Issue 10083003: Make checkperms.py look for shebang.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10083003: Make checkperms.py look for shebang. (Closed)

Created:
8 years, 8 months ago by M-A Ruel

Modified:
8 years, 8 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make checkperms.py look for shebang. This should enable removing most (if not all) of the whitelist. R=thestig@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132258

Patch Set 2 : Address review comment #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	tools/checkperms/checkperms.py	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

lgtm https://chromiumcodereview.appspot.com/10083003/diff/1/tools/checkperms/checkperms.py File tools/checkperms/checkperms.py (right): https://chromiumcodereview.appspot.com/10083003/diff/1/tools/checkperms/checkperms.py#newcode181 tools/checkperms/checkperms.py:181: if f.read(3).startswith('#!/'): startswith -> ==

8 years, 8 months ago (2012-04-13 19:09:49 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10083003/3001

8 years, 8 months ago (2012-04-13 19:11:22 UTC) #3

Change committed as 132258

Expand Messages | Collapse Messages

Issue 10083003: Make checkperms.py look for shebang. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address review comment #

Messages