Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 10083001: MIPS: Add isolate accessor to AccessorInfo and Arguments. (Closed)

Created:
8 years, 8 months ago by kalmard
Modified:
8 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Add isolate accessor to AccessorInfo and Arguments. Port r11306 (36b58f7). Original commit message: This passes the isolate through to API callback functions so that it is available through AccessorInfo and Arguments. This allows bindings to avoid unnecessary TLS lookups to retrieve the current isolate. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11319

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated based on review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -29 lines) Patch
M src/mips/stub-cache-mips.cc View 1 12 chunks +34 lines, -29 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kalmard
8 years, 8 months ago (2012-04-13 10:42:24 UTC) #1
Michael Starzinger
LGTM (with one comment). I'll land it once comment is addressed. https://chromiumcodereview.appspot.com/10083001/diff/1/src/mips/stub-cache-mips.cc File src/mips/stub-cache-mips.cc (right): ...
8 years, 8 months ago (2012-04-13 11:41:50 UTC) #2
kalmard
Thanks for the review, I updated the CL based on your suggestion. http://codereview.chromium.org/10083001/diff/1/src/mips/stub-cache-mips.cc File src/mips/stub-cache-mips.cc ...
8 years, 8 months ago (2012-04-13 11:51:54 UTC) #3
Michael Starzinger
8 years, 8 months ago (2012-04-13 13:44:38 UTC) #4
Landed as r11319.

Powered by Google App Engine
This is Rietveld 408576698