Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 10082016: [mac] Enable the 'Hide Extension' checkbox on expanded save dialogs. (Closed)

Created:
8 years, 8 months ago by csilv
Modified:
8 years, 8 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Visibility:
Public.

Description

[mac] Enable the 'Hide Extension' checkbox on expanded save dialogs. The save dialog, when viewed in the expanded mode, will show the 'Hide Extension' checkbox with this change. This will apply to all save dialogs. Note that this checkbox is only visible if Finder's 'Show all extensions' settings is turned OFF. I don't see any downside to having this checkbox available. Other apps that appear to always enable this checkbox: Safari, Mail, TextEdit. BUG=123118 TEST=Save a web-page, expand window, 'Hide Extension' checkbox should be visible. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132422

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/cocoa/select_file_dialog_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
csilv
+mark for review
8 years, 8 months ago (2012-04-13 19:49:09 UTC) #1
Mark Mentovai
8 years, 8 months ago (2012-04-16 15:30:53 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698