Modify the sharding_supervisor to understand gtest's xml output.

Modify the sharding_supervisor to understand gtest's xml output.

We need to be able to merge it back into one final xml file if we
want the flakiness dashboard to work.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132342

[M-A Ruel, 2012-04-13 20:07:43]

lgtm with a few nits

https://chromiumcodereview.appspot.com/10082014/diff/1/tools/sharding_supervi...
File tools/sharding_supervisor/sharding_supervisor.py (right):

https://chromiumcodereview.appspot.com/10082014/diff/1/tools/sharding_supervi...
tools/sharding_supervisor/sharding_supervisor.py:77: return None
"return None" is not strictly necessary.

https://chromiumcodereview.appspot.com/10082014/diff/1/tools/sharding_supervi...
tools/sharding_supervisor/sharding_supervisor.py:91: args.append(new_arg)
args.append('--gtest_output=' + current_value + value)
is fine to me.

https://chromiumcodereview.appspot.com/10082014/diff/1/tools/sharding_supervi...
tools/sharding_supervisor/sharding_supervisor.py:102: current_arg =
'--gtest_output=' + current_value
args.remove('--gtest_output=' + current_value)
is fine to me.

https://chromiumcodereview.appspot.com/10082014/diff/1/tools/sharding_supervi...
tools/sharding_supervisor/sharding_supervisor.py:108: def AppendToXML(final_xml,
generic_path, shard):
Can you add a one-liner docstring?

https://chromiumcodereview.appspot.com/10082014/diff/1/tools/sharding_supervi...
tools/sharding_supervisor/sharding_supervisor.py:110: shard_xml_file =
open(path)
with open(path) as shard_xml_file:

https://chromiumcodereview.appspot.com/10082014/diff/1/tools/sharding_supervi...
tools/sharding_supervisor/sharding_supervisor.py:119: testcases =
shard_node.getElementsByTagName('testcase')
I still think you should have used ElementTree instead of minidom but that's
fine.

https://chromiumcodereview.appspot.com/10082014/diff/1/tools/sharding_supervi...
tools/sharding_supervisor/sharding_supervisor.py:374: final_xml =
AppendToXML(final_xml, xml_path, i)
can you do the str(i) here instead of at line 109? It'd look safer to me than
let's say doing a str(None) by error.

https://chromiumcodereview.appspot.com/10082014/diff/1/tools/sharding_supervi...
tools/sharding_supervisor/sharding_supervisor.py:375: final_file =
open(xml_path, 'w')
with open(xml_path, 'w') as final_file:
  final_xml.writexml(final_file)

[nsylvain, 2012-04-13 20:30:58]

https://chromiumcodereview.appspot.com/10082014/diff/1/tools/sharding_supervi...
File tools/sharding_supervisor/sharding_supervisor.py (right):

https://chromiumcodereview.appspot.com/10082014/diff/1/tools/sharding_supervi...
tools/sharding_supervisor/sharding_supervisor.py:91: args.append(new_arg)
On 2012/04/13 20:07:44, Marc-Antoine Ruel wrote:
> args.append('--gtest_output=' + current_value + value)
> is fine to me.

Done.

https://chromiumcodereview.appspot.com/10082014/diff/1/tools/sharding_supervi...
tools/sharding_supervisor/sharding_supervisor.py:102: current_arg =
'--gtest_output=' + current_value
On 2012/04/13 20:07:44, Marc-Antoine Ruel wrote:
> args.remove('--gtest_output=' + current_value)
> is fine to me.

Done.

https://chromiumcodereview.appspot.com/10082014/diff/1/tools/sharding_supervi...
tools/sharding_supervisor/sharding_supervisor.py:108: def AppendToXML(final_xml,
generic_path, shard):
On 2012/04/13 20:07:44, Marc-Antoine Ruel wrote:
> Can you add a one-liner docstring?

Done.

https://chromiumcodereview.appspot.com/10082014/diff/1/tools/sharding_supervi...
tools/sharding_supervisor/sharding_supervisor.py:110: shard_xml_file =
open(path)
On 2012/04/13 20:07:44, Marc-Antoine Ruel wrote:
> with open(path) as shard_xml_file:

Done.

https://chromiumcodereview.appspot.com/10082014/diff/1/tools/sharding_supervi...
tools/sharding_supervisor/sharding_supervisor.py:375: final_file =
open(xml_path, 'w')
On 2012/04/13 20:07:44, Marc-Antoine Ruel wrote:
> with open(xml_path, 'w') as final_file:
>   final_xml.writexml(final_file)

Done.

[M-A Ruel, 2012-04-13 20:40:45]

lgtm

https://chromiumcodereview.appspot.com/10082014/diff/4001/tools/sharding_supe...
File tools/sharding_supervisor/sharding_supervisor.py (right):

https://chromiumcodereview.appspot.com/10082014/diff/4001/tools/sharding_supe...
tools/sharding_supervisor/sharding_supervisor.py:367: xml, xml_path =
output_arg.split(':')
xml, xml_path = output_arg.split(':', 1)

https://chromiumcodereview.appspot.com/10082014/diff/4001/tools/sharding_supe...
tools/sharding_supervisor/sharding_supervisor.py:372: final_file =
open(xml_path, 'w')
with open(xml_path, 'w') as final_file:

[nsylvain, 2012-04-13 22:04:58]

https://chromiumcodereview.appspot.com/10082014/diff/4001/tools/sharding_supe...
File tools/sharding_supervisor/sharding_supervisor.py (right):

https://chromiumcodereview.appspot.com/10082014/diff/4001/tools/sharding_supe...
tools/sharding_supervisor/sharding_supervisor.py:367: xml, xml_path =
output_arg.split(':')
On 2012/04/13 20:40:45, Marc-Antoine Ruel wrote:
> xml, xml_path = output_arg.split(':', 1)

Done.

https://chromiumcodereview.appspot.com/10082014/diff/4001/tools/sharding_supe...
tools/sharding_supervisor/sharding_supervisor.py:372: final_file =
open(xml_path, 'w')
On 2012/04/13 20:40:45, Marc-Antoine Ruel wrote:
> with open(xml_path, 'w') as final_file:

Done.