Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10082008: Aura demo fix (Closed)

Created:
8 years, 8 months ago by oshima
Modified:
8 years, 8 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix order #

Patch Set 3 : test fix #

Patch Set 4 : export #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -192 lines) Patch
M chrome/browser/ui/views/accessibility_event_router_views_unittest.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M content/test/test_renderer_host.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M ui/aura/aura.gyp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/demo/demo_main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + ui/aura/single_monitor_manager.h View 1 2 3 3 chunks +6 lines, -7 lines 0 comments Download
A + ui/aura/single_monitor_manager.cc View 3 chunks +1 line, -3 lines 0 comments Download
M ui/aura/test/aura_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
D ui/aura/test/single_monitor_manager.h View 1 chunk +0 lines, -59 lines 0 comments Download
D ui/aura/test/single_monitor_manager.cc View 1 chunk +0 lines, -103 lines 0 comments Download
M ui/views/test/views_test_base.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M ui/views/widget/native_widget_aura_unittest.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
oshima
8 years, 8 months ago (2012-04-13 16:27:19 UTC) #1
sadrul
Sweet! Thanks! LGTM
8 years, 8 months ago (2012-04-13 16:29:55 UTC) #2
oshima
+sky for OWNERS review
8 years, 8 months ago (2012-04-13 16:34:39 UTC) #3
sky
LGTM http://codereview.chromium.org/10082008/diff/1/ui/aura/aura.gyp File ui/aura/aura.gyp (right): http://codereview.chromium.org/10082008/diff/1/ui/aura/aura.gyp#newcode91 ui/aura/aura.gyp:91: 'single_monitor_manager.h', nit: sort.
8 years, 8 months ago (2012-04-13 16:54:41 UTC) #4
oshima
On 2012/04/13 16:54:41, sky wrote: > LGTM > > http://codereview.chromium.org/10082008/diff/1/ui/aura/aura.gyp > File ui/aura/aura.gyp (right): > ...
8 years, 8 months ago (2012-04-13 17:35:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/10082008/4001
8 years, 8 months ago (2012-04-13 17:40:42 UTC) #6
commit-bot: I haz the power
Try job failure for 10082008-4001 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-13 18:04:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/10082008/4004
8 years, 8 months ago (2012-04-13 22:00:51 UTC) #8
commit-bot: I haz the power
Change committed as 132294
8 years, 8 months ago (2012-04-13 23:25:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/10082008/3043
8 years, 8 months ago (2012-04-14 00:33:29 UTC) #10
commit-bot: I haz the power
8 years, 8 months ago (2012-04-14 00:58:04 UTC) #11 
Try job failure for 10082008-3043 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

Powered by Google App Engine
This is Rietveld 408576698