Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 10082001: Convert the logging ui_test to a browser_test. (Closed)

Created:
8 years, 8 months ago by jam
Modified:
8 years, 8 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Convert the logging ui_test to a browser_test. I spent a lot of time trying to find a way to make the assertion and crash dump locator tests non-flaky and shardable. But it's not really possible, because the log file is per binary, and the dumps all get put into the same directory. That means that running with sharding will give erronous results. Also even if we weren't sharding, there's still race conditions looking at the disk for a crash dump. I kept a test which looks for a notification that we crashed (instead of looking on disk). If this breaks in the field, I believe we'll notice very quickly from the canary builds (do we also have breakpad tests for this?). For the assert/check tests, I think if something breaks there developers will very quickly find it. BUG=121574 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132684

Patch Set 1 #

Patch Set 2 : Fix checkdeps #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -323 lines) Patch
A + chrome/browser/logging_chrome_browsertest.cc View 1 2 chunks +36 lines, -111 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 2 chunks +1 line, -1 line 0 comments Download
D chrome/common/logging_chrome_uitest.cc View 1 2 1 chunk +0 lines, -174 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
M content/public/common/content_switches.cc View 1 2 2 chunks +0 lines, -8 lines 0 comments Download
M content/renderer/renderer_main.cc View 1 2 1 chunk +5 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
8 years, 8 months ago (2012-04-13 18:01:18 UTC) #1
cpu_(ooo_6.6-7.5)
I don't think we run the breakpad tests on the bots.
8 years, 8 months ago (2012-04-17 19:46:33 UTC) #2
cpu_(ooo_6.6-7.5)
8 years, 8 months ago (2012-04-17 19:52:38 UTC) #3
I think the missing piece which is the out-of-process breakpad integration might
be best covered in an omaha test. I'll start the email thread.

lgtm

Powered by Google App Engine
This is Rietveld 408576698