Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2641)

Unified Diff: Source/web/WebDevToolsFrontendImpl.cpp

Issue 1008163003: Oilpan: move WebDevToolsFrontend to the heap. Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: trace WebLocalFrameImpl's reference Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebDevToolsFrontendImpl.h ('k') | Source/web/WebLocalFrameImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebDevToolsFrontendImpl.cpp
diff --git a/Source/web/WebDevToolsFrontendImpl.cpp b/Source/web/WebDevToolsFrontendImpl.cpp
index 7cc3dec68ad527d9f89e144f1907a4423778c4ed..659c5bcb00dec7ae08cc674b8e591e0c045af00c 100644
--- a/Source/web/WebDevToolsFrontendImpl.cpp
+++ b/Source/web/WebDevToolsFrontendImpl.cpp
@@ -43,25 +43,7 @@
namespace blink {
-WebDevToolsFrontend* WebDevToolsFrontend::create(
- WebView* view,
- WebDevToolsFrontendClient* client,
- const WebString& applicationLocale)
-{
- return new WebDevToolsFrontendImpl(toWebLocalFrameImpl(view->mainFrame()), client);
-}
-
-WebDevToolsFrontend* WebDevToolsFrontend::create(
- WebLocalFrame* frame,
- WebDevToolsFrontendClient* client,
- const WebString& applicationLocale)
-{
- return new WebDevToolsFrontendImpl(toWebLocalFrameImpl(frame), client);
-}
-
-WebDevToolsFrontendImpl::WebDevToolsFrontendImpl(
- WebLocalFrameImpl* webFrame,
- WebDevToolsFrontendClient* client)
+WebDevToolsFrontendImpl::WebDevToolsFrontendImpl(WebLocalFrameImpl* webFrame, WebDevToolsFrontendClient* client)
: m_webFrame(webFrame)
, m_client(client)
{
@@ -70,9 +52,16 @@ WebDevToolsFrontendImpl::WebDevToolsFrontendImpl(
WebDevToolsFrontendImpl::~WebDevToolsFrontendImpl()
{
+ // Q: where is this cleared?
ASSERT(!m_devtoolsHost);
}
+DEFINE_TRACE(WebDevToolsFrontendImpl)
+{
+ visitor->trace(m_webFrame);
+ visitor->trace(m_devtoolsHost);
+}
+
void WebDevToolsFrontendImpl::didClearWindowObject(WebLocalFrameImpl* frame)
{
if (m_webFrame == frame) {
« no previous file with comments | « Source/web/WebDevToolsFrontendImpl.h ('k') | Source/web/WebLocalFrameImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698