Issue 10081037: views: Fix painting views with layers in RTL locale.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10081037: views: Fix painting views with layers in RTL locale. (Closed)

Created:
8 years, 8 months ago by sadrul

Modified:
8 years, 8 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

views: Fix painting views with layers in RTL locale. This fixes RTL painting in the launcher. BUG=112070 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132409

Patch Set 1 #

Patch Set 2 : test #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -5 lines)			Patch
	M	ui/views/view.cc	View		5 chunks	+5 lines, -5 lines	0 comments	Download
	M	ui/views/view_unittest.cc	View	1	2 chunks	+60 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

8 years, 8 months ago (2012-04-16 14:37:41 UTC) #2

LGTM

http://codereview.chromium.org/10081037/diff/2001/ui/views/view_unittest.cc
File ui/views/view_unittest.cc (right):

http://codereview.chromium.org/10081037/diff/2001/ui/views/view_unittest.cc#n...
ui/views/view_unittest.cc:2875: std::string locale =
l10n_util::GetApplicationLocale("");
"" -> std::string()

Expand Messages | Collapse Messages