Don't register more than one 'connect' event handler per HostTableEntry. Don't create more than one…

remoting/webapp/host_table_entry.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Class representing an entry in the host-list portion of the home screen.
  */
 
 'use strict';
@@ skipping 35 matching lines @@
   this.onRename_ = function(host) {};
   /** @type {undefined|function(remoting.HostTableEntry):void} @private */
   this.onDelete_ = function(host) {};
   // References to event handlers so that they can be removed.
   /** @type {function():void} @private */
   this.onBlurReference_ = function() {};
   /** @type {function():void} @private */
   this.onConfirmDeleteReference_ = function() {};
   /** @type {function():void} @private */
   this.onCancelDeleteReference_ = function() {};
-  /** @type {function():void} @private */
-  this.onConnectReference_ = function() {};
+  /** @type {function():void?} @private */
+  this.onConnectReference_ = null;
 };
 
 /**
  * Create the HTML elements for this entry and set up event handlers.
  * @param {remoting.Host} host The host, as obtained from Apiary.
  * @param {function(remoting.HostTableEntry):void} onRename Callback for
  *     rename operations.
  * @param {function(remoting.HostTableEntry):void} onDelete Callback for
  *     delete operations.
  * @return {void} Nothing.
@@ skipping 70 matching lines @@
   };
   editButton.addEventListener('click', beginRename, true);
   if (opt_deleteButton) {
     /** @param {Event} event The click event. */
     var confirmDelete = function(event) {
       that.showDeleteConfirmation_();
       event.stopPropagation();
     };
     opt_deleteButton.addEventListener('click', confirmDelete, false);
   }
-  var hostUrl = chrome.extension.getURL('main.html') +
-      '?mode=me2me&hostId=' + encodeURIComponent(host.hostId);
-  this.onConnectReference_ = function() { window.location.assign(hostUrl); };
-
   this.updateStatus();
 };
 
 /**
  * Update the row to reflect the current status of the host (online/offline and
  * clickable/unclickable).
  *
  * @param {boolean=} opt_forEdit True if the status is being updated in order
  *     to allow the host name to be edited.
  * @return {void} Nothing.
  */
 remoting.HostTableEntry.prototype.updateStatus = function(opt_forEdit) {
   var clickToConnect = this.host.status == 'ONLINE' && !opt_forEdit;
   if (clickToConnect) {
-    this.tableRow.addEventListener('click', this.onConnectReference_, false);
+    if (!this.onConnectReference_) {
+      /** @type {remoting.HostTableEntry} */
+      var that = this;
+      this.onConnectReference_ = function() {
+        var hostUrl = chrome.extension.getURL('main.html') +
+            '?mode=me2me&hostId=' + encodeURIComponent(that.host.hostId);
+        window.location.assign(hostUrl);
+      };
+      this.tableRow.addEventListener('click', this.onConnectReference_, false);
+    }
     this.tableRow.classList.add('clickable');
     this.tableRow.title = chrome.i18n.getMessage(
         /*i18n-content*/'TOOLTIP_CONNECT', this.host.hostName);
   } else {
-    this.tableRow.removeEventListener('click', this.onConnectReference_, false);
+    if (this.onConnectReference_) {
+      this.tableRow.removeEventListener('click', this.onConnectReference_,
+                                        false);
+      this.onConnectReference_ = null;
+    }
     this.tableRow.classList.remove('clickable');
     this.tableRow.title = '';
   }
   var showOffline = this.host.status != 'ONLINE';
   if (showOffline) {
     this.tableRow.classList.remove('host-online');
     this.tableRow.classList.add('host-offline');
   } else {
     this.tableRow.classList.add('host-online');
     this.tableRow.classList.remove('host-offline');
@@ skipping 135 matching lines @@
  * @return {void} Nothing.
  * @private
  */
 remoting.HostTableEntry.prototype.onKeydown_ = function(event) {
   if (event.which == 27) {  // Escape
     this.removeEditBox_();
   } else if (event.which == 13) {  // Enter
     this.commitRename_();
   }
 };